RFC clocksource / timekeeping rework V2
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest12 patches 19 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/12 | introduce timekeeping_leap_insertinclude/ kernel/ kernel/ | +10 | 1 reply | |
| 2/12 | remove clocksource inline functionsinclude/ kernel/ | +18 | 3 replies | |
| 3/12 | cleanup clocksource selectionarch/ include/ kernel/ +2 more | +62 | 0 replies | |
| 4/12 | clocksource watchdog highres enablementkernel/ | +22 | 0 replies | |
| 5/12 | clocksource watchdog resume logickernel/ | +15 | 0 replies | |
| 6/12 | clocksource watchdog refactoringkernel/ | +68 | 0 replies | |
| 7/12 | clocksource watchdog workinclude/ kernel/ | +40 | 0 replies | |
| 8/12 | introduce struct timekeeperarch/ include/ kernel/ +1 more | +152 | 0 replies | |
| 9/12 | add xtime_shift and ntp_error_shift to struct timekeeperkernel/ | +18 | 2 replies | |
| 10/12 | move NTP adjusted clock multiplier to struct timekeeperarch/ include/ kernel/ | +27 | 9 replies | |
| 11/12 | timekeeper read clock helper functionskernel/ | +38 | 3 replies | |
| 12/12 | update clocksource with stop_machineinclude/ kernel/ kernel/ | +73 | 0 replies |
Reviews trailers per patch
1 of 12 patches has a Reviewed-by or Acked-by.
| Patch | John Stultz |
|---|---|
| 1/12 | |
| 2/12 | A-b |
| 3/12 | |
| 4/12 | |
| 5/12 | |
| 6/12 | |
| 7/12 | |
| 8/12 | |
| 9/12 | |
| 10/12 | |
| 11/12 | |
| 12/12 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [RFC][patch 00/12] clocksource / timekeeping rework V2
Greetings,
version 2 of the clocksource / timekeeping cleanup patches. The series has grown quite a bit, what started with a simple idea to replace the tick based clocksource update with stop_machine is now a full fledged code rework.
The code is working on s390 and on my Athlon system at home which has a broken tsc clocksource:
[ 0.000000] Fast TSC calibration using PIT [ 0.000341] hpet clockevent registered [ 0.000343] HPET: 3 timers in total, 0 timers will be used for per-cpu timer [ 0.204021] hpet0: at MMIO 0xfefff000, IRQs 2, 8, 31 [ 0.204027] hpet0: 3 comparators, 32-bit 25.000000 MHz counter [ 0.208007] Switching to clock hpet [ 0.211544] Switched to high resolution mode on CPU 0 [ 0.211960] Switched to high resolution mode on CPU 1 [ 8.000020] Clocksource tsc unstable (delta = -172310085 ns)
So the clocksource switch via stop_machine and the clocksource watchdog are working. I keep the fingers crossed that nothing else breaks.
The patch set is based on todays upstream tree plus the patches from the tip tree, if anyone wants to try them you need to pull from the master branch of
git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-tip
There is still more room for improvement. Some sore points are:
1) The cycle_last value still is in the struct clocksource. It should be in the struct timekeeper but the check against cycles_last in the read function of the TSC clock source makes it hard.
2) read_persistent_clock returns seconds. With a really good initial time source this is not very precise. read_persistent_clock should return a struct timespec.
3) xtime, raw_time, total_sleep_time, timekeeping_suspended, jiffies, the ntp state and probably a few other values may be better located in the struct timekeeper as well.
and a few more I forgot.
Many thanks to John who pushed me into the right directions.
Signature · 4 lines
blue skies, Martin. "Reality continues to ruin my life." - Calvin.