Skip to content

matroxfb: Code cleanups

Jean Delvare linux-fbdev 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5matroxfb: Make CONFIG_FB_MATROX_MULTIHEAD=y mandatoryDocumentation/fb/matroxfb.txt drivers/video/Kconfig drivers/video/matrox/matroxfb_base.c +2 more+1 -700 replies
2/5matroxfb: Get rid of unneeded macros ACCESS_FBINFO and MINFOdrivers/video/matrox/g450_pll.c drivers/video/matrox/i2c-matroxfb.c drivers/video/matrox/matroxfb_DAC1064.c +9 more+838 -8430 replies
3/5matroxfb: Get rid of unneeded macros WPMINFO and friendsdrivers/video/matrox/g450_pll.c drivers/video/matrox/g450_pll.h drivers/video/matrox/i2c-matroxfb.c +12 more+581 -4450 replies
4/5matroxfb: Get rid of unneeded macro MINFO_FROMdrivers/video/matrox/matroxfb_accel.c drivers/video/matrox/matroxfb_base.c drivers/video/matrox/matroxfb_base.h +3 more+32 -350 replies
5/5matroxfb: Get rid of CONFIG_FB_MATROX_32MBdrivers/video/matrox/matroxfb_DAC1064.c drivers/video/matrox/matroxfb_base.c drivers/video/matrox/matroxfb_base.h+0 -190 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/5] matroxfb: Code cleanups

Hi Petr,

This is a 5-piece patchset cleaning up the matroxfb driver:

[PATCH 1/5] matroxfb: Make CONFIG_FB_MATROX_MULTIHEAD=y mandatory [PATCH 2/5] matroxfb: Get rid of unneeded macros ACCESS_FBINFO and MINFO [PATCH 3/5] matroxfb: Get rid of unneeded macros WPMINFO and friends [PATCH 4/5] matroxfb: Get rid of unneeded macro MINFO_FROM [PATCH 5/5] matroxfb: Get rid of CONFIG_FB_MATROX_32MB

 Documentation/fb/matroxfb.txt           |    4 
 drivers/video/Kconfig                   |   20 
 drivers/video/matrox/g450_pll.c         |  209 ++++----
 drivers/video/matrox/g450_pll.h         |    8 
 drivers/video/matrox/i2c-matroxfb.c     |   18 
 drivers/video/matrox/matroxfb_DAC1064.c |  616 +++++++++++++------------
 drivers/video/matrox/matroxfb_DAC1064.h |    4 
 drivers/video/matrox/matroxfb_Ti3026.c  |  260 +++++-----
 drivers/video/matrox/matroxfb_accel.c   |  129 ++---
 drivers/video/matrox/matroxfb_accel.h   |    2 
 drivers/video/matrox/matroxfb_base.c    |  770 +++++++++++++++-----------------
 drivers/video/matrox/matroxfb_base.h    |   80 ---
 drivers/video/matrox/matroxfb_crtc2.c   |  160 +++---
 drivers/video/matrox/matroxfb_g450.c    |  185 ++++---
 drivers/video/matrox/matroxfb_g450.h    |    8 
 drivers/video/matrox/matroxfb_maven.c   |   48 +
 drivers/video/matrox/matroxfb_misc.c    |  296 ++++++------
 drivers/video/matrox/matroxfb_misc.h    |   15 
 18 files changed, 1436 insertions(+), 1396 deletions(-)

The diffstat is impressive, but that's really only mecanical changes being applied driver-wide. There's no actual code change and there should be zero runtime difference before and after the patchset. I've tested it on my Millennium to make sure.

Signature · 7 lines
Jean Delvare

------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day 
trial. Simplify your report design, integration and deployment - and focus on 
what you do best, core application coding. Discover what's new with 
Crystal Reports now.  http://p.sf.net/sfu/bobj-july