Skip to content

fix scan_thread, sysfs stuff, LUN addressing problem

Stephen M. Cameron linux-scsi lkml 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest17 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17Remove sysfs entries for logical drives on driver cleanup.drivers/block/cciss.c+4 -10 replies
2/17Use one scan thread per controller and fix hang during rmmoddrivers/block/cciss.c drivers/block/cciss.h+141 -220 replies
3/17Allow triggering of rescan of logical drive topology via sysfs entryDocumentation/ABI/testing/sysfs-bus-pci-devices-cciss drivers/block/cciss.c+40 -30 replies
4/17Remove some unused code in rebuild_lun_table()drivers/block/cciss.c+0 -80 replies
5/17Dynamically allocate struct device for each logical drive as needed.drivers/block/cciss.c drivers/block/cciss.h+73 -270 replies
6/17Rearrange logical drive sysfs code to make the "changing a disk" path work.drivers/block/cciss.c+10 -100 replies
7/17Handle failure of blk_init_queue gracefully in cciss_add_disk.drivers/block/cciss.c+3 -00 replies
8/17Handle cases when cciss_add_disk fails.drivers/block/cciss.c+25 -100 replies
9/17Handle special case for sysfs attributes of the first logical drive.drivers/block/cciss.c+14 -40 replies
10/17Clear all sysfs-exposed data for deleted logical drives.drivers/block/cciss.c+21 -100 replies
11/17Fix usage_count check in rebuild_lun_table when triggered via sysfs.drivers/block/cciss.c+21 -120 replies
12/17Fix excessive gendisk freeing bug on driver unload.drivers/block/cciss.c+8 -70 replies
13/17Silence noisy per-disk messages output by cciss_read_capacitydrivers/block/cciss.c+0 -50 replies
14/17Preserve all 8 bytes of LUN ID for logical drives.drivers/block/cciss.c drivers/block/cciss.h+25 -250 replies
15/17Add lunid attribute to each logical drive in /sysDocumentation/ABI/testing/sysfs-bus-pci-devices-cciss drivers/block/cciss.c+33 -00 replies
16/17Add a "raid_level" attribute to each logical drive in /sysDocumentation/ABI/testing/sysfs-bus-pci-devices-cciss drivers/block/cciss.c+31 -00 replies
17/17Add usage_count attribute to each logical drive in /sysDocumentation/ABI/testing/sysfs-bus-pci-devices-cciss drivers/block/cciss.c+27 -00 replies

Reviews trailers per patch

3 of 17 patches have a Reviewed-by or Acked-by.

PatchMike Miller
1/17A-b
2/17A-b
3/17A-b
4/17
5/17
6/17
7/17
8/17
9/17
10/17
11/17
12/17
13/17
14/17
15/17
16/17
17/17

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [cciss: PATCH 00/17] fix scan_thread, sysfs stuff, LUN addressing problem

The following series cleans up the broken scan_thread code, allows triggering of the scan_thread via sysfs, dynamically allocates the struct device for each logical drive as needed instead of all at once at driver init time, fixes a bug in logical drive addressing (seen on MSA2012), and adds lunid, raid_level, and usage_count attributes in sysfs for each logical drive.

---

Andrew Patterson (3):
Allow triggering of rescan of logical drive topology via sysfs entry Use one scan thread per controller and fix hang during rmmod Remove sysfs entries for logical drives on driver cleanup.

Stephen M. Cameron (14):
Add usage_count attribute to each logical drive in /sys
Add a "raid_level" attribute to each logical drive in /sys
Add lunid attribute to each logical drive in /sys
Preserve all 8 bytes of LUN ID for logical drives.
Silence noisy per-disk messages output by cciss_read_capacity Fix excessive gendisk freeing bug on driver unload.
Fix usage_count check in rebuild_lun_table when triggered via sysfs. Clear all sysfs-exposed data for deleted logical drives. Handle special case for sysfs attributes of the first logical drive. Handle cases when cciss_add_disk fails.
Handle failure of blk_init_queue gracefully in cciss_add_disk. Rearrange logical drive sysfs code to make the "changing a disk" path work. Dynamically allocate struct device for each logical drive as needed. Remove some unused code in rebuild_lun_table()

 .../ABI/testing/sysfs-bus-pci-devices-cciss        |   28 +
 drivers/block/cciss.c                              |  551 +++++++++++++++-----
 drivers/block/cciss.h                              |   11 
 3 files changed, 461 insertions(+), 129 deletions(-)
Signature · 1 line
-- steve