Skip to content

Suspend/resume support for some 83xx/85xx/86xx boards

Anton Vorontsov linuxppc-dev 2 versions – Applied

Status from this message: applied to next.

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 13 repliesApplied
  2. v25 patches 7 repliesSuperseded

Patches in v4 Applied

#Subject and filesSizeRepliesApplied
1/7powerpc/qe: Make qe_reset() code path safe for repeated invocationarch/powerpc/include/asm/qe.h arch/powerpc/sysdev/cpm_common.c arch/powerpc/sysdev/qe_lib/qe.c+12 -71 reply
2/7powerpc/qe: QE also shuts down on MPC8568arch/powerpc/include/asm/qe.h arch/powerpc/sysdev/qe_lib/qe.c+22 -141 reply
3/7powerpc/qe: Implement QE driver for handling resume on MPC85xxarch/powerpc/sysdev/qe_lib/qe.c+34 -01 reply
4/7powerpc/85xx/86xx: Add suspend/resume supportarch/powerpc/Kconfig arch/powerpc/sysdev/Makefile arch/powerpc/sysdev/fsl_pmc.c+99 -11 reply
5/7powerpc/85xx: Add power management support for MPC85xxMDS boardsarch/powerpc/boot/dts/mpc8568mds.dts arch/powerpc/boot/dts/mpc8569mds.dts arch/powerpc/platforms/85xx/mpc85xx_mds.c+153 -787 replies
6/7powerpc/86xx: Add power management support for MPC8610HPCD boardsDocumentation/powerpc/dts-bindings/fsl/board.txt arch/powerpc/boot/dts/mpc8610_hpcd.dts arch/powerpc/platforms/86xx/mpc8610_hpcd.c+74 -41 reply
7/7powerpc/83xx: Add power management support for MPC83xx QE boardsarch/powerpc/boot/dts/kmeter1.dts arch/powerpc/boot/dts/mpc832x_mds.dts arch/powerpc/boot/dts/mpc832x_rdb.dts +2 more+43 -01 reply

Reviews trailers per patch

4 of 7 patches have a Reviewed-by or Acked-by.

PatchScott Wood
1/7
2/7
3/7
4/7A-b
5/7A-b
6/7A-b
7/7A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v4 thread

Cover letter [PATCH v4 0/7] Suspend/resume support for some 83xx/85xx/86xx boards
Quoted 6 lines · Anton Vorontsov

On Mon, Sep 14, 2009 at 03:45:10PM -0500, Scott Wood wrote:
[...]

Quoted 4 lines
Quoted 3 lines

You can't request the firmware in the qe driver's ->suspend() routine necause the firmware may be on e.g. NFS filesystem or USB stick (implies having QE Ethernet or QE USB fully functional).

Quoted 6 lines
Quoted 2 lines

Is there any way for software to read out the current firmware from the device, or is it write-only?

Hm, I didn't look into iram stuff that much, but seemingly I can read it back and save. In the end, it's just a ram that we access in a weird way... Let me try it.

Okay... that might sound silly, but the microcode stuff isn't needed at all. While the QE really shuts down, its iram is preserved. I'm not sure why it didn't work for me before, but now it does work. Heh.

Note that QE reset is still needed, it's QE microcode reload that we don't need. I was also curious if MPC8568 QE needs reset after sleep, so I unpacked the board and tested it. It needs the reset just as MPC8569. I also found a paragraph in reference manual that somewhat proves "QE turns off during sleep" behaviour.

So here is a new patch set. Changes:

- Removed QE stuff from fsl_pmc;
- New patches added:
powerpc/qe: QE also shuts down on MPC8568 powerpc/qe: Implement QE driver for handling resume on MPC85xx

Thanks,

Signature · 3 lines
Anton Vorontsov
email: [email protected]
irc://irc.freenode.net/bd2