Skip to content

ACPI: cleanups for hotplug

Bjorn Helgaas linux-acpi 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v3 Latest17 patches 4 repliesIn review
  2. v119 patches 3 repliesApplied

Changes in v3 from the cover letter

- refreshed to apply on current acpi-test (193a6dec1c0246a).
- removed deferred execution patches (already in acpi-test)
- added fix for acpiphp_ibm.c bug introduced by ACPICA acpi_get_object_info() changes (unrelated to this series, only here for convenience)

Patches in v3 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/17ACPICA: fixup after acpi_get_object_info() changedrivers/pci/hotplug/acpiphp_ibm.c+0 -10 replies
2/17ACPI: add debug for device additiondrivers/acpi/scan.c+10 -20 replies
3/17ACPI: remove unused acpi_bus_scan_fixed() argumentdrivers/acpi/scan.c+2 -50 replies
4/17ACPI: remove redundant "handle" and "parent" argumentsdrivers/acpi/scan.c+12 -150 replies
5/17ACPI: save device_type in acpi_devicedrivers/acpi/scan.c include/acpi/acpi_bus.h+3 -10 replies
6/17ACPI: use device_type rather than comparing HIDdrivers/acpi/scan.c+4 -60 replies
7/17ACPI: remove acpi_device_set_context() "type" argumentdrivers/acpi/scan.c+15 -170 replies
8/17ACPI: remove redundant "type" argumentsdrivers/acpi/scan.c+7 -70 replies
9/17ACPI: remove unnecessary argument checkingdrivers/acpi/scan.c+2 -60 replies
10/17ACPI: add acpi_bus_get_parent() and remove "parent" argumentsdrivers/acpi/scan.c+37 -130 replies
11/17ACPI: convert acpi_bus_scan() to operate on an acpi_handledrivers/acpi/scan.c+17 -170 replies
12/17ACPI: enumerate namespace before adding functional fixed hardware devicesdrivers/acpi/scan.c+2 -20 replies
13/17ACPI: identify device tree root by null parent pointer, not ACPI_BUS_TYPEdrivers/acpi/scan.c include/acpi/acpi_bus.h+13 -84 replies
14/17ACPI: use acpi_walk_namespace() to enumerate devicesdrivers/acpi/scan.c+74 -1220 replies
15/17ACPI: add acpi_bus_get_status_handle()drivers/acpi/bus.c include/acpi/acpi_bus.h+24 -270 replies
16/17ACPI: factor out device type and status checkingdrivers/acpi/scan.c+52 -770 replies
17/17ACPI: handle re-enumeration, when acpi_devices might already existdrivers/acpi/scan.c+11 -80 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v3 yet.

Read the v3 thread

Cover letter [PATCH v3 00/17] ACPI: cleanups for hotplug

I'm working to make the Linux/ACPI code handle hotplug notification events. This should ultimately allow us to remove the existing hotplug code scattered through the ACPI device drivers.

This is a long series of cleanups that should cause no functional change, but will make it easier to call acpi_bus_scan() from the notification path.

Comments and testing reports welcome. Boot logs with CONFIG_ACPI_DEBUG=y and "acpi.debug_layer=0x00010000" will be helpful in debugging any issues.

Original posting: http://marc.info/?l=linux-acpi&m=124907619701194&w=2

Changes from v2 to v3:
- refreshed to apply on current acpi-test (193a6dec1c0246a).
- removed deferred execution patches (already in acpi-test)
- added fix for acpiphp_ibm.c bug introduced by ACPICA acpi_get_object_info() changes (unrelated to this series, only here for convenience)

Changes from initial post to v2:
- refreshed to apply on current acpi-test (0beab01e5b2c448).
- fixed memory leak in acpi_add_single_object() debug code
- added ACPI_IS_ROOT_DEVICE() macro (Len)

---

Bjorn Helgaas (17):
ACPICA: fixup after acpi_get_object_info() change
ACPI: add debug for device addition
ACPI: remove unused acpi_bus_scan_fixed() argument
ACPI: remove redundant "handle" and "parent" arguments
ACPI: save device_type in acpi_device
ACPI: use device_type rather than comparing HID
ACPI: remove acpi_device_set_context() "type" argument
ACPI: remove redundant "type" arguments
ACPI: remove unnecessary argument checking
ACPI: add acpi_bus_get_parent() and remove "parent" arguments
ACPI: convert acpi_bus_scan() to operate on an acpi_handle
ACPI: enumerate namespace before adding functional fixed hardware devices
ACPI: identify device tree root by null parent pointer, not ACPI_BUS_TYPE
ACPI: use acpi_walk_namespace() to enumerate devices
ACPI: add acpi_bus_get_status_handle()
ACPI: factor out device type and status checking
ACPI: handle re-enumeration, when acpi_devices might already exist

 drivers/acpi/bus.c                |   49 ++--
 drivers/acpi/scan.c               |  427 +++++++++++++++++--------------------
 drivers/pci/hotplug/acpiphp_ibm.c |    1 
 include/acpi/acpi_bus.h           |    6 -
 4 files changed, 217 insertions(+), 266 deletions(-)
Signature · 1 line
Bjorn