Skip to content

net_tx_t: network device transmit return value change

Stephen Hemminger linux-hams linux-wireless netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest19 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/19netdev: change transmit to limited range typeinclude/linux/netdevice.h+13 -92 replies
2/19netdev: convert pseudo-devices to netdev_tx_tdrivers/ieee1394/eth1394.c net/8021q/vlan_dev.c net/bluetooth/bnep/netdev.c +14 more+30 -310 replies
3/19convert ATM drivers to netdev_tx_tnet/atm/br2684.c net/atm/clip.c net/atm/lec.c +1 more+12 -60 replies
4/19convert hamradio drivers to netdev_txreturnt_tdrivers/net/hamradio/6pack.c drivers/net/hamradio/bpqether.c drivers/net/hamradio/hdlcdrv.c +5 more+12 -91 reply
5/19isdn: convert to netdev_tx_tdrivers/isdn/hysdn/hysdn_net.c drivers/isdn/i4l/isdn_net.c+4 -30 replies
6/19usbnet: convert to netdev_tx_tdrivers/net/usb/catc.c drivers/net/usb/cdc-phonet.c drivers/net/usb/hso.c +6 more+21 -140 replies
7/19tokenring: convert to netdev_tx_tdrivers/net/tokenring/3c359.c drivers/net/tokenring/ibmtr.c drivers/net/tokenring/lanstreamer.c +3 more+29 -180 replies
8/19wan: convert drivers to netdev_tx_tdrivers/net/wan/cosa.c drivers/net/wan/cycx_x25.c drivers/net/wan/dlci.c +18 more+57 -460 replies
9/19hdlc: convert to netdev_tx_tdrivers/char/pcmcia/synclink_cs.c drivers/char/synclink.c drivers/char/synclink_gt.c +2 more+16 -200 replies
10/19netdev: convert pcmcia drivers to netdev_tx_tdrivers/net/pcmcia/3c574_cs.c drivers/net/pcmcia/3c589_cs.c drivers/net/pcmcia/axnet_cs.c +4 more+27 -140 replies
11/19irda: convert to netdev_tx_tdrivers/net/irda/ali-ircc.c drivers/net/irda/donauboe.c drivers/net/irda/irda-usb.c +13 more+64 -370 replies
12/19netdev: convert pseudo drivers to netdev_tx_tdrivers/firewire/net.c drivers/net/bonding/bond_main.c drivers/net/can/vcan.c +10 more+27 -290 replies
13/19uwb: convert to netdev_tx_tdrivers/uwb/i1480/i1480u-wlp/i1480u-wlp.h drivers/uwb/i1480/i1480u-wlp/tx.c+4 -21 reply
14/19tulip: convert drivers to netdev_tx_tdrivers/net/tulip/de2104x.c drivers/net/tulip/de4x5.c drivers/net/tulip/dmfe.c +4 more+23 -173 replies
15/193com: convert drivers to netdev_tx_tdrivers/net/3c501.c drivers/net/3c501.h drivers/net/3c505.c +6 more+26 -200 replies
16/19intel: convert drivers to netdev_tx_tdrivers/net/e100.c drivers/net/e1000/e1000_main.c drivers/net/e1000e/netdev.c +4 more+30 -231 reply
17/19appletalk: convert drivers to netdev_tx_tdrivers/net/appletalk/cops.c drivers/net/appletalk/ipddp.c drivers/net/appletalk/ltpc.c+9 -60 replies
18/19wireless: convert drivers to netdev_tx_tdrivers/net/wimax/i2400m/netdev.c drivers/net/wireless/airo.c drivers/net/wireless/arlan-main.c +25 more+92 -651 reply
19/19netdev: convert bulk of drivers to netdev_tx_tdrivers/ieee802154/fakehard.c drivers/net/8139cp.c drivers/net/8139too.c +99 more+253 -1731 reply

Reviews trailers per patch

5 of 19 patches have a Reviewed-by or Acked-by.

PatchThomas SailerDavid DillowJeff KirsherGrant GrundlerDavid Vrabel
1/19
2/19
3/19
4/19A-b
5/19
6/19
7/19
8/19
9/19
10/19
11/19
12/19
13/19A-b
14/19A-b
15/19
16/19A-b
17/19
18/19
19/19A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [PATCH 00/19] net_tx_t: network device transmit return value change

This is a little change over a lot of files. It changes the return value of network device transmit from an integer to an enum type (like irqreturn_t). This allows compiler to warn about stupid code that tries to return -ENOBUFS or other mistakes like that. All the code that did that is gone, but it would be better to try and do some decent type checking.

This patch converts all the x86 drivers (except staging). Other drivers will work but produce a warning until converted.