RFC PCI/ACPI PM: Propagate wake-up enable upstream
Get series with b4
b4 am [email protected]Versions newest first
- v1 RFC Latest4 patches 14 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/4 | PCI PM: Simplify PCI wake-up codedrivers/ drivers/ | +21 | 0 replies | |
| 1/4 | PCI PM: Simplify PCI wake-up codedrivers/ drivers/ | +21 | 0 replies | |
| 2/4 | PCI/ACPI PM: Rework some debug messagesdrivers/ drivers/ | +10 | 0 replies | |
| 2/4 | PCI/ACPI PM: Rework some debug messagesdrivers/ drivers/ | +10 | 0 replies | |
| 3/4 | PCI PM: Introduce device flag wakeup_prepareddrivers/ include/ | +9 | 0 replies | |
| 3/4 | PCI PM: Introduce device flag wakeup_prepareddrivers/ include/ | +9 | 0 replies | |
| 4/4 | PCI/ACPI PM: Propagate wake-up enable for devices w/o ACPI supportdrivers/ drivers/ drivers/ +3 more | +63 | 16 replies | |
| 4/4 | PCI/ACPI PM: Propagate wake-up enable for devices w/o ACPI supportdrivers/ drivers/ drivers/ +3 more | +63 | 0 replies | |
| 4/4 | ACPI PM: Replace wakeup.prepared with reference counterdrivers/ drivers/ drivers/ +1 more | +39 | 0 replies | |
| 4/4 | ACPI PM: Replace wakeup.prepared with reference counterdrivers/ drivers/ drivers/ +1 more | +39 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [RFC][PATCH 0/4] PCI/ACPI PM: Propagate wake-up enable upstream
Quoted 22 lines · Rafael J. Wysocki
Quoted 21 lines · Rafael J. Wysocki
Quoted 8 lines · Matthew Garrett
Quoted 4 lines · Rafael J. Wysocki
Updated patch is appended, but there's a problem with it. Namely, when the root bridge GPE is shared with other devices, those devices are also enabled to wake up and they may be kind of "interesting" (on one of my test boxes they include the ethernet and audio adapters). I'm not sure what to do about that.
Perhaps only enable it if a child device is enabled?
Well, the problem is that we have to enable the devices that share the GPE to wake up together, but the child device we _really_ want to wake-up need not be any of them.
Also, the child device may be enabled to wake up after we've run the "glue" code.
Well, perhaps it's better to rework
pci_enable_wake()so that it, if the device doesn't have an ACPI handle and is not PCIe, it will go and enable the root bridge to wake up as well?
Quoted 8 lines
Quoted 3 lines
I wonder what about the bridges between the desired wake-up device and the root bridge. I guess they also should be enabled to wake-up, so that they can forward the PME# in case the system is designed this way.
Below is a prototype of what I was thinking of, although I'm not sure if that's enough.
Comments welcome.
Hm, no comments. :-(
In the meantime I spent some time on this problem and prepared the following series of patches.
The last one has to be tested on the system it was invented for, but that's going to take some time.
Comments welcome.
Rafael