Skip to content

increase rcutorture intensity and fix a couple resulting bugs

Paul E. McKenney lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3rcutorture: Occasionally delay readers enough to make RCU force_quiescent_statekernel/rcutorture.c+9 -64 replies
2/3Need to update rnp->gpnum if preemptable RCU is to be reliable.kernel/rcutree.c+5 -12 replies
3/3Initialize multi-level RCU grace periods holding lockskernel/rcutree.c+12 -292 replies

Reviews trailers per patch

All 3 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSteven Rostedt
SeriesA-b
1/3A-b A-b
2/3A-b A-b
3/3A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH tip/core/rcu 0/3] increase rcutorture intensity and fix a couple resulting bugs

This patch series increases the intensity of rcutorture testing for TREE_PREEMPT_RCU and provides fixes for a couple resulting bugs.

o Make rcutorture's RCU read-side critical sections occasionally
spin for a few tens of milliseconds, which greatly increases the probability that they will be preempted and that quiescent states will be forced. Yes, this does uncover some bugs in TREE_PREEMPT_RCU (though TREE_RCU passes with flying colors).

o Fix a bug where rnp->gpnum was not being updated. This
increases TREE_PREEMPT_RCU's reliability considerably, though bugs still remain.

o Make the initialization of multi-node trees of rcu_node
structures unconditionally acquire rnp->lock. This simplifies the code a bit and will make it easier to allow grace-period initialization become preemptable, should this be needed.

Next steps include applying review comments, adding expedited grace periods, and chasing down remaining bugs. Longer term, RCU priority boosting.

 b/kernel/rcutorture.c |   16 +++++++++-------
 b/kernel/rcutree.c    |    7 +++++--
 kernel/rcutree.c      |   42 ++++++++++++------------------------------
 3 files changed, 26 insertions(+), 39 deletions(-)