Skip to content

Some improvements to request deferral and related code

NeilBrown linux-nfs 1 version Applied

Status from this message: Thanks, applied.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest9 patches 15 repliesApplied

Patches in v1 Applied

#Subject and filesSizeRepliesApplied
1/9sunrpc/cache: change cache_defer_req to return -ve error, not boolean.net/sunrpc/cache.c+5 -51 reply
2/9sunrpc/cache: simplify cache_fresh_locked and cache_fresh_unlocked.net/sunrpc/cache.c+10 -130 replies
3/9sunrpc/cache: use list_del_init for the list_head entries in cache_deferred_reqnet/sunrpc/cache.c+4 -41 reply
4/9sunrpc/cache: avoid variable over-loading in cache_defer_reqnet/sunrpc/cache.c+9 -91 reply
5/9sunrpc/cache: allow threads to block while waiting for cache update.include/linux/sunrpc/cache.h net/sunrpc/cache.c net/sunrpc/svc_xprt.c+57 -13 replies
6/9sunrpc/cache: retry cache lookups that return -ETIMEDOUTfs/nfsd/export.c net/sunrpc/auth_gss/svcauth_gss.c net/sunrpc/svcauth_unix.c+52 -67 replies
7/9nfsd/idmap: drop special request deferal in favour of improved default.fs/nfsd/nfs4idmap.c+11 -941 reply
8/9sunrpc/cache: change deferred-request hash table to use hlist.include/linux/sunrpc/cache.h net/sunrpc/cache.c+13 -190 replies
9/9sunrpc: close connection when a request is irretrievably lost.include/linux/sunrpc/svcauth.h net/sunrpc/auth_gss/svcauth_gss.c net/sunrpc/svc.c +1 more+25 -130 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] Some improvements to request deferral and related code

Hi,
here again are those patches from request deferral improvement set that have not yet been applied.

I had previously missed the cache lookups in svcauth_gss, and have now made them work correctly.

I also discovered that for NFSv4.1 and later, the current deferral scheme is disabled once the request gets into the NFS layer (i.e. out of the RPC layer). I don't know that 4.0 doesn't disable it as well
- maybe the problems it can cause are more severe with 4.1? With this patch set included it might be acceptable to disable the current scheme for 4.0.

I believe this is ready for wider testing and probably mainline inclusion.

Thanks,
NeilBrown

---

NeilBrown (9):
sunrpc: close connection when a request is irretrievably lost. sunrpc/cache: change deferred-request hash table to use hlist. nfsd/idmap: drop special request deferal in favour of improved default. sunrpc/cache: retry cache lookups that return -ETIMEDOUT sunrpc/cache: allow threads to block while waiting for cache update. sunrpc/cache: avoid variable over-loading in cache_defer_req sunrpc/cache: use list_del_init for the list_head entries in cache_deferred_req sunrpc/cache: simplify cache_fresh_locked and cache_fresh_unlocked. sunrpc/cache: change cache_defer_req to return -ve error, not boolean.

 fs/nfsd/export.c                  |   18 ++++++
 fs/nfsd/nfs4idmap.c               |  105 ++++------------------------------
 include/linux/sunrpc/cache.h      |    5 +-
 include/linux/sunrpc/svcauth.h    |   10 ++-
 net/sunrpc/auth_gss/svcauth_gss.c |   29 ++++++---
 net/sunrpc/cache.c                |  115 ++++++++++++++++++++++++-------------
 net/sunrpc/svc.c                  |    3 +
 net/sunrpc/svc_xprt.c             |   11 ++++
 net/sunrpc/svcauth_unix.c         |   34 +++++++++--
 9 files changed, 176 insertions(+), 154 deletions(-)
Signature · 1 line
Signature