Skip to content

__builtin_unreachable

Roland McGrath linux-arch lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2UNREACHABLE() macroinclude/linux/compiler-gcc4.h include/linux/compiler.h+22 -09 replies
2/2x86: BUG(): use UNREACHABLE()arch/x86/include/asm/bug.h+2 -20 replies

Reviews trailers per patch

None of the 2 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchWANG Cong
SeriesR-b
1/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/2] __builtin_unreachable

The latest GCC has a better way than "for (;;)" to indicate that a code path cannot be reached due to reasons the compiler doesn't understand (such as code in an asm). These patches provide UNREACHABLE() as a macro to hide the details of this, and then use it for the BUG() macro on x86, saving some dead code otherwise generated.

Other arch's BUG() may want to this too instead of "for (;;)" or __builtin_trap.

There are numerous matches from "git grep -n 'for *(;;) *;'" but it takes someone who knows each bit of code to know where that means UNREACHABLE() and where it really wants an infinite loop.

The following changes since commit 74fca6a42863ffacaf7ba6f1936a9f228950f657:
Linus Torvalds (1):

        Linux 2.6.31

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/frob/linux-2.6-roland.git topic/builtin_unreachable

Roland McGrath (2):

      UNREACHABLE() macro
      x86: BUG(): use UNREACHABLE()
 arch/x86/include/asm/bug.h    |    4 ++--
 include/linux/compiler-gcc4.h |   13 +++++++++++++
 include/linux/compiler.h      |    9 +++++++++
 3 files changed, 24 insertions(+), 2 deletions(-)

Thanks,
Roland