Skip to content

cciss: fix scan_thread, sysfs stuff, dynamically allocate per drive structure

Stephen M. Cameron linux-scsi lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest20 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/20cciss: Remove sysfs entries for logical drives on driver cleanup.drivers/block/cciss.c+4 -10 replies
2/20cciss: Use one scan thread per controller and fix hang during rmmoddrivers/block/cciss.c drivers/block/cciss.h+141 -220 replies
3/20cciss: Allow triggering of rescan of logical drive topology via sysfs entryDocumentation/ABI/testing/sysfs-bus-pci-devices-cciss drivers/block/cciss.c+40 -30 replies
4/20cciss: Remove some unused code in rebuild_lun_table()drivers/block/cciss.c+0 -80 replies
5/20cciss: Dynamically allocate struct device for each logical drive as needed.drivers/block/cciss.c drivers/block/cciss.h+73 -270 replies
6/20cciss: Rearrange logical drive sysfs code to make the "changing a disk" path work.drivers/block/cciss.c+10 -100 replies
7/20cciss: Handle failure of blk_init_queue gracefully in cciss_add_disk.drivers/block/cciss.c+3 -00 replies
8/20cciss: Handle cases when cciss_add_disk fails.drivers/block/cciss.c+25 -100 replies
9/20cciss: Handle special case for sysfs attributes of the first logical drive.drivers/block/cciss.c+14 -40 replies
10/20cciss: Clear all sysfs-exposed data for deleted logical drives.drivers/block/cciss.c+21 -100 replies
11/20cciss: Fix usage_count check in rebuild_lun_table when triggered via sysfs.drivers/block/cciss.c+21 -120 replies
12/20cciss: Fix excessive gendisk freeing bug on driver unload.drivers/block/cciss.c+8 -70 replies
13/20cciss: Silence noisy per-disk messages output by cciss_read_capacitydrivers/block/cciss.c+0 -50 replies
14/20cciss: Preserve all 8 bytes of LUN ID for logical drives.drivers/block/cciss.c drivers/block/cciss.h+25 -250 replies
15/20cciss: Don't check h->busy_initializing in cciss_open().drivers/block/cciss.c+1 -10 replies
16/20cciss: Add lunid attribute to each logical drive in /sysDocumentation/ABI/testing/sysfs-bus-pci-devices-cciss drivers/block/cciss.c+33 -00 replies
17/20cciss: fix some magic numbers in the raid-level decodingdrivers/block/cciss.c+2 -30 replies
18/20cciss: Add a "raid_level" attribute to each logical drive in /sysDocumentation/ABI/testing/sysfs-bus-pci-devices-cciss drivers/block/cciss.c+31 -00 replies
19/20cciss: Add usage_count attribute to each logical drive in /sysDocumentation/ABI/testing/sysfs-bus-pci-devices-cciss drivers/block/cciss.c+27 -00 replies
20/20cciss: Dynamically allocate the drive_info_struct for each logical drive.drivers/block/cciss.c drivers/block/cciss.h+168 -1300 replies

Reviews trailers per patch

3 of 20 patches have a Reviewed-by or Acked-by.

PatchMike Miller
1/20A-b
2/20A-b
3/20A-b
4/20
5/20
6/20
7/20
8/20
9/20
10/20
11/20
12/20
13/20
14/20
15/20
16/20
17/20
18/20
19/20
20/20

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/20] cciss: fix scan_thread, sysfs stuff, dynamically allocate per drive structure

The following series cleans up the broken scan_thread code, allows triggering of the scan_thread via sysfs, dynamically allocates the per device structure for each logical drive as needed instead of all at once at driver init time, fixes a bug in logical drive addressing (seen on MSA2012), and adds lunid, raid_level, and usage_count attributes in sysfs for each logical drive.

---

Andrew Patterson (3):
cciss: Allow triggering of rescan of logical drive topology via sysfs entry
cciss: Use one scan thread per controller and fix hang during rmmod
cciss: Remove sysfs entries for logical drives on driver cleanup.

Stephen M. Cameron (17):
cciss: Dynamically allocate the drive_info_struct for each logical drive.
cciss: Add usage_count attribute to each logical drive in /sys
cciss: Add a "raid_level" attribute to each logical drive in /sys
cciss: fix some magic numbers in the raid-level decoding
cciss: Add lunid attribute to each logical drive in /sys
cciss: Don't check h->busy_initializing in cciss_open().
cciss: Preserve all 8 bytes of LUN ID for logical drives.
cciss: Silence noisy per-disk messages output by cciss_read_capacity
cciss: Fix excessive gendisk freeing bug on driver unload.
cciss: Fix usage_count check in rebuild_lun_table when triggered via sysfs.
cciss: Clear all sysfs-exposed data for deleted logical drives.
cciss: Handle special case for sysfs attributes of the first logical drive.
cciss: Handle cases when cciss_add_disk fails.
cciss: Handle failure of blk_init_queue gracefully in cciss_add_disk.
cciss: Rearrange logical drive sysfs code to make the "changing a disk" path work.
cciss: Dynamically allocate struct device for each logical drive as needed.
cciss: Remove some unused code in rebuild_lun_table()

 .../ABI/testing/sysfs-bus-pci-devices-cciss        |   28 +
 drivers/block/cciss.c                              |  743 +++++++++++++++-----
 drivers/block/cciss.h                              |   12 
 3 files changed, 576 insertions(+), 207 deletions(-)
Signature · 1 line
-- steve