Skip to content

Futex cleanups and race fix

Darren Hart lkml 1 version In review

Get series with b4
b4 am 20090922052452.8717.39673.stgit@Aeon

Versions newest first

  1. v1 Latest5 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5futex: correct futex_wait_requeue_pi() commentarykernel/futex.c+3 -31 reply
2/5futex: correct queue_me and unqueue_me commentarykernel/futex.c+29 -121 reply
3/5futex: make function kernel-doc commentary consistentkernel/futex.c+21 -201 reply
4/5futex: correct futex_q woken state commentarykernel/futex.c+16 -161 reply
5/5futex: fix wakeup race by setting TASK_INTERRUPTIBLE before queue_mekernel/futex.c+3 -125 replies

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchPeter Zijlstra
1/5A-b
2/5A-b
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/5] Futex cleanups and race fix

The following series corrects several innacurate comments in the futex code as well as reformat some of the existing comments to be mostly consistent throughout futex.c. The final patch fixes a nasty little race in the requeue pi code resulting in missed wakeups and hung userspace application threads.

Cc Thomas Gleixner <[email protected]>
Cc Peter Zijlstra <[email protected]>
Cc Steven Rostedt <[email protected]>
Cc Ingo Molnar <[email protected]>
CC Eric Dumazet <[email protected]>
CC Dinakar Guniguntala <[email protected]>
CC John Stultz <[email protected]>

---

Darren Hart (5):
futex: fix wakeup race by setting TASK_INTERRUPTIBLE before queue_me
futex: correct futex_q woken state commentary
futex: make function kernel-doc commentary consistent
futex: correct queue_me and unqueue_me commentary
futex: correct futex_wait_requeue_pi() commentary

 kernel/futex.c |  135 ++++++++++++++++++++++++++++++--------------------------
 1 files changed, 72 insertions(+), 63 deletions(-)
Signature · 3 lines
Darren Hart
IBM Linux Technology Center
Real-Time Linux Team