Series to make copy_from_user to a stack slot provable right
Status from this message: Applied, thanks.
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | Fix bound checks for copy_from_user in the acpi /proc codedrivers/ | +2 | 0 replies | |
| 2/9 | Simplify bound checks in nvram for copy_from_userdrivers/ | +9 | 0 replies | |
| 3/9 | Add bound checks in wext for copy_from_usernet/ | +6 | 0 replies | |
| 4/9 | Simplify bound checks in the MTRR codearch/ | +12 | 1 reply | |
| 5/9 | Add bound checks in acpi/video for copy_from_userdrivers/ | +14 | 0 replies | |
| 6/9 | Simplify bound checks in cifs for copy_from_userfs/ | +5 | 0 replies | |
| 7/9 | Simplify bound checks in capabilities for copy_from_userkernel/ | +6 | 3 replies | |
| 8/9 | Add explicit bound checks in mm/migrate.cmm/ | +6 | 3 replies | |
| 9/9 | Add explicit bound checks in net/socket.cnet/ | +6 | 5 replies |
Reviews trailers per patch
2 of 9 patches have a Reviewed-by or Acked-by.
| Patch | James Morris | KOSAKI Motohiro |
|---|---|---|
| 1/9 | ||
| 2/9 | ||
| 3/9 | ||
| 4/9 | ||
| 5/9 | ||
| 6/9 | ||
| 7/9 | A-b | |
| 8/9 | R-b | |
| 9/9 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/9] Series to make copy_from_user to a stack slot provable right
[PATCH 0/9] Series to make copy_from_user to a stack slot provable right
This series contains a series of patches that, when applied, make every copy_from_user() in a make allyesconfig to a (direct) stack slot provable-by-gcc to have a correct size.
This is useful because if we fix all of these, we can make the non-provable case an error, as an indication of a possible security hole.
Now the series has 4 types of patches
1) changes where the original code really was missing checks
2) changes where the checks were coded so complex and games were played with types, that I (and the compiler) couldn't be sure if it was correct or not
3) changes where we're hitting a small gcc missing optimization, but where a simplification of the code allows gcc to prove things anyway.
(http://gcc.gnu.org/bugzilla/show_bug.cgi?id=41477 is filed for this)
4) a case in sys_socketcall where Dave Miller and co were very smart in optimizing the code to the point where it's not reasonable for gcc to realize the result is ok.
Signature · 3 lines
Arjan van de Ven Intel Open Source Technology Centre For development, discussion and tips for power savings, visit http://www.lesswatts.org