Skip to content

rcu: more review feedback

Paul E. McKenney lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2rcu: Apply review feedback from Josh Triplett, part 3include/linux/rcupdate.h kernel/rcutree.c+12 -121 reply
1/2rcu: Apply review feedback from Josh Triplett, part 3include/linux/rcupdate.h kernel/rcutree.c+12 -122 replies
2/2rcu: Apply review feedback from Josh Triplett, part 4kernel/rcutree.c kernel/rcutree.h kernel/rcutree_plugin.h+40 -292 replies
2/2rcu: Apply review feedback from Josh Triplett, part 4kernel/rcutree.c kernel/rcutree.h kernel/rcutree_plugin.h+40 -292 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchJosh Triplett
SeriesA-b
1/2A-b
1/2A-b
2/2
2/2

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH tip/core/rcu 0/2] rcu: more review feedback

This patchset applies the last of the review comments:

o Whitespace fixes, updated comments, and code movement.

o Improve an existing abstraction and introduce two additional
abstractions for traversing the rcu_node tree.

Issues remaining:

o I can force hangs given sufficient rcutorture testing in
conjunction with random CPU-hotplug operations. I am working on a simpler interface between RCU and CPU hotplug that I believe will clear this up.

o TREE_PREEMPT_RCU currently uses the TREE_RCU variant of
synchronize_rcu_expedited, which is wrong. I am working on an expedited variant for TREE_PREEMPT_RCU, but will fall back on synchronize_rcu() for the short term if it gives me much trouble.

o The IPI hyperactivity from call_rcu() noted by Nick Piggin.
I believe I have identified a clean design for a fix for this.

o Make RCU less dependent on IPIs for forcing grace periods
(but this might be best deferred to 2.6.33).

o RCU priority boosting (2.6.33!).

o TINY_PREEMPT_RCU (2.6.33!).

o Squeeze another 400 bytes or so out of TINY_RCU (2.6.33!).