PCI, PNP: print resources consistently
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
Patches in v2 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/9 | vsprintf: fix io/mem resource widthlib/ | +2 | 0 replies | |
| 2/9 | vsprintf: add %pR support for IRQ and DMA resourceslib/ | +23 | 0 replies | |
| 3/9 | vsprintf: add %pR decoding and %pr for raw struct resourcelib/ | +47 | 3 replies | |
| 4/9 | PCI: set IORESOURCE_MEM_64 before printing resourcedrivers/ | +4 | 0 replies | |
| 5/9 | PCI: trivial bridge resource factorizationdrivers/ | +24 | 0 replies | |
| 6/9 | PCI: print resources consistently with %pRdrivers/ drivers/ drivers/ +2 more | +29 | 0 replies | |
| 7/9 | x86/PCI: print resources consistently with %pRarch/ arch/ | +18 | 0 replies | |
| 8/9 | ia64/PCI: print resources consistently with %pRarch/ | +19 | 0 replies | |
| 9/9 | PNP: print resources consistently with %pRdrivers/ drivers/ drivers/ +1 more | +19 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.
Cover letter [PATCH v2 0/9] PCI, PNP: print resources consistently
These enhance %pR so we can print resource types and flags more easily. This doesn't really add anything (other than a couple new messages about host bridge apertures), but hopefully it will make things more consistent and a bit easier to debug. Sample change (with "pci=use_crs"):
-pci 0000:00:03.0: reg 10 32bit mmio: [0xf6000000-0xf6ffffff]
-pci 0000:00:03.0: reg 14 io port: [0x2400-0x24ff]
-pci 0000:00:03.0: reg 18 32bit mmio: [0xf5ff0000-0xf5ff0fff]
-pci 0000:00:03.0: reg 30 32bit mmio pref: [0x000000-0x01ffff]
+pci_root PNP0A03:00: host bridge window [io 0x0000-0x0cff]
+pci_root PNP0A03:00: host bridge window [io 0x0000-0x2cfe]
+pci_root PNP0A03:00: host bridge window [io 0x03b0-0x03bb]
+pci_root PNP0A03:00: host bridge window [io 0x03c0-0x03df]
+pci_root PNP0A03:00: host bridge window [mem 0xf5d00000-0xf6ffffff]
+pci_root PNP0A03:00: host bridge window [mem 0x000a0000-0x000bffff]
+pci 0000:00:03.0: reg 10: [mem 0xf6000000-0xf6ffffff]
+pci 0000:00:03.0: reg 14: [io 0x2400-0x24ff]
+pci 0000:00:03.0: reg 18: [mem 0xf5ff0000-0xf5ff0fff]
+pci 0000:00:03.0: reg 30: [mem 0x00000000-0x0001ffff pref]Changes from initial post to v2:
- tidied vsprintf stack buffer to shrink and compute size more accurately (Joe Perches)
- use %pR for decoding, %pr for "raw" (with type and flags) instead of adding %pRt and %pRf
- split cleanup from printk changes for easier review
I plan some future patches to add more messages and change some dev_dbg() to dev_info(), so this series is strictly to change the resource formatting.
---
Bjorn Helgaas (9):
vsprintf: fix io/mem resource width
vsprintf: add %pR support for IRQ and DMA resources
vsprintf: add %pR decoding and %pr for raw struct resource
PCI: set IORESOURCE_MEM_64 before printing resource
PCI: trivial bridge resource factorization
PCI: print resources consistently with %pR x86/PCI: print resources consistently with %pR ia64/PCI: print resources consistently with %pR
PNP: print resources consistently with %pR
arch/ia64/pci/pci.c | 24 ++++++++++--- arch/x86/pci/acpi.c | 15 ++++++-- arch/x86/pci/i386.c | 13 +++---- drivers/pci/pci.c | 4 +- drivers/pci/probe.c | 29 +++++----------- drivers/pci/quirks.c | 2 + drivers/pci/setup-bus.c | 82 +++++++++++++++++++------------------------- drivers/pci/setup-res.c | 20 +++++------ drivers/pnp/quirks.c | 13 ++----- drivers/pnp/resource.c | 10 ++--- drivers/pnp/support.c | 43 +++-------------------- drivers/pnp/system.c | 14 +++----- lib/vsprintf.c | 87 ++++++++++++++++++++++++++++++++++++++--------- 13 files changed, 183 insertions(+), 173 deletions(-)
Signature · 1 line
Bjorn