ACPI: dock: code hygiene
Get series with b4
b4 am [email protected]Versions newest first · linked by author and title
- v4 Latest6 patches 6 repliesIn review
- v36 patches 4 repliesSuperseded
- v26 patches 2 repliesSuperseded
Earlier versions · 1
| Version | Posted | Patches | Replies | Status |
|---|---|---|---|---|
| v1 | 6 patches | 3 replies | Superseded |
Changes in v4 from the cover letter
- defensively code in case sysfs_create_group() fails and sysfs_remove_group() can't handle removing a non-existent group; suggested by Dmitry Torokhov
Patches in v4 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | ACPI: dock: convert sysfs attributes to an attribute_groupdrivers/ | +24 | 3 replies | |
| 2/6 | ACPI: dock: combine add|alloc_dock_dependent_devicedrivers/ | +19 | 0 replies | |
| 3/6 | ACPI: dock: remove global 'dock_device_name'drivers/ | +1 | 0 replies | |
| 4/6 | ACPI: dock: dock_add - hoist up platform_device_register_simple()drivers/ | +7 | 0 replies | |
| 5/6 | ACPI: dock: add struct dock_station * directly to platform device datadrivers/ | +13 | 0 replies | |
| 6/6 | ACPI: dock: minor whitespace and style cleanupsdrivers/ | +45 | 0 replies |
Reviews trailers per patch
1 of 6 patches has a Reviewed-by or Acked-by.
| Patch | Dmitry Torokhov |
|---|---|
| 1/6 | R-b |
| 2/6 | |
| 3/6 | |
| 4/6 | |
| 5/6 | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH v4 0/6] ACPI: dock: code hygiene
This is v4 of a modest attempt to clean up the dock driver.
As before, compile tested only, since I don't have any machines that provide _DCK.
Thanks.
/ac
v3 -> v4:
- defensively code in case sysfs_create_group() fails and sysfs_remove_group() can't handle removing a non-existent group; suggested by Dmitry Torokhov
v2 -> v3:
- now using an attribute_group, as suggested by Dmitry Torokhov
v1 -> v2:
- changed how we add platform device data, based on Shaohua Li's review
---
Alex Chiang (6):
ACPI: dock: convert sysfs attributes to an attribute_group
ACPI: dock: combine add|alloc_dock_dependent_device
ACPI: dock: remove global 'dock_device_name'
ACPI: dock: dock_add - hoist up platform_device_register_simple()
ACPI: dock: add struct dock_station * directly to platform device data
ACPI: dock: minor whitespace and style cleanups
drivers/acpi/dock.c | 266 ++++++++++++++++++--------------------------------- 1 files changed, 93 insertions(+), 173 deletions(-)