Skip to content

iPAQ h3100/h3600 work for 2.6.33

Russell King - ARM Linux linux-arm-kernel 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 20 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 20 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/20] iPAQ h3100/h3600 work for 2.6.33
Quoted 3 lines · Dmitry Artamonow

Compile and run tested on iPAQs h3150 and h3635 with CF jacket. Patches are mostly checkpatch clean - there's some comments exceeding 80-line limit, but otherwise all code should be ok.

I don't really care about the 80 character line limit in two circumstances:
1. if a printk format string needs to go over the limit, so be it.
2. comments against #defines when it's reasonable for them to be there provided its not excessive.

Looking at these patches, it seems sane.

Quoted 3 lines

Also, please note, that patches are generated with "-C" flag of git-format-patch for easier review. If there's problems with applying, use patches from URL above - they're generated without "-C".

That's fine, and the patches to me at least look fine as well. The only thing which gives me slight concern is the:

	if (!gpio_request()) {
		gpio_direction_output();
		gpio_free();
	}

stuff, but I guess you can't get around that easily, especially if those GPIOs only become available at some time later. It is something that eventually needs to be addressed though - consider that this can lead to unexpected (and silent) failures if the GPIOs aren't available when another driver initializes, and can't (eg) turn on the IrDA tranceiver.