Skip to content

x86 insn decoder bugfixes

Masami Hiramatsu lkml 1 version In review

Get series with b4
b4 am 20091027204156.30545.96425.stgit@harusame

Versions newest first

  1. v1 Latest10 patches 26 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10x86: Fix SSE opcode map bugarch/x86/lib/x86-opcode-map.txt+5 -51 reply
2/10x86: Merge INAT_REXPFX into INAT_PFX_*arch/x86/include/asm/inat.h arch/x86/lib/insn.c arch/x86/tools/gen-insn-attr-x86.awk+24 -201 reply
3/10x86: Add pclmulq to x86 opcode maparch/x86/lib/x86-opcode-map.txt+1 -01 reply
4/10x86: AVX instruction set decoder supportarch/x86/include/asm/inat.h arch/x86/include/asm/insn.h arch/x86/lib/inat.c +3 more+431 -2331 reply
5/10x86: Add Intel FMA instructions to x86 opcode maparch/x86/lib/x86-opcode-map.txt+33 -11 reply
6/10kprobe-tracer: Compare both of event-name and event-group to find probekernel/trace/trace_kprobe.c+5 -31 reply
7/10perf/probes: Exit searching after finding target functiontools/perf/util/probe-finder.c+2 -21 reply
8/10perf/probes: Change command-line option of perf-probetools/perf/builtin-probe.c+18 -101 reply
9/10perf/probes: Change probepoint syntax of perf-probetools/perf/builtin-probe.c tools/perf/util/probe-finder.c tools/perf/util/probe-finder.h+123 -701 reply
10/10perf/probes: Support function entry relative line numbertools/perf/builtin-probe.c tools/perf/util/probe-finder.c tools/perf/util/probe-finder.h+70 -251 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH -tip perf/probes 00/10] x86 insn decoder bugfixes

Hi Ingo,

Here are bugfixes and some enhances of x86-insn decoder and perf-probe.
- x86 insn decoder supports AVX and FMA.
- perf-probe syntax change.
- perf-probe supports function-relative line number.
- minor bugfixes.

New perf-probe syntax is below:

perf probe 'PROBE'

or

  perf probe --add 'PROBE'

where, PROBE is

<source>:<line-number>

or

<function>[:<rel-lineno>|+<byte-offset>|%return][@<source>]

e.g.

perf probe 'schedule:10@kernel/sched.c'

puts a probe at 10th line from entry line of schedule() function in kernel/sched.c." and

perf probe 'vmalloc%return'

puts a return probe at the returning of vmalloc.

TODO:
- Support --line option to show which lines user can probe.
- Support lazy string matching.

Thank you,

---

Masami Hiramatsu (10):
perf/probes: Support function entry relative line number perf/probes: Change probepoint syntax of perf-probe perf/probes: Change command-line option of perf-probe perf/probes: Exit searching after finding target function
kprobe-tracer: Compare both of event-name and event-group to find probe
x86: Add Intel FMA instructions to x86 opcode map
x86: AVX instruction set decoder support
x86: Add pclmulq to x86 opcode map
x86: Merge INAT_REXPFX into INAT_PFX_*
x86: Fix SSE opcode map bug

 arch/x86/include/asm/inat.h          |   68 ++++-
 arch/x86/include/asm/insn.h          |   43 +++
 arch/x86/lib/inat.c                  |   12 +
 arch/x86/lib/insn.c                  |   54 ++++
 arch/x86/lib/x86-opcode-map.txt      |  464 +++++++++++++++++++---------------
 arch/x86/tools/gen-insn-attr-x86.awk |  100 +++++--
 kernel/trace/trace_kprobe.c          |    8 -
 tools/perf/builtin-probe.c           |  201 +++++++++------
 tools/perf/util/probe-finder.c       |   93 +++++--
 tools/perf/util/probe-finder.h       |    4 
 10 files changed, 695 insertions(+), 352 deletions(-)
Signature · 6 lines
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: [email protected]