Skip to content

Clean up the sdio_uart driver and fix the tty code

Alan Cox linux-mmc lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 8 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6sdio_uart: refcount the tty objectsdrivers/mmc/card/sdio_uart.c+41 -170 replies
2/6sdio_uart: Move the open lockdrivers/mmc/card/sdio_uart.c+9 -110 replies
3/6sdio_uart: Switch to the open/close helpersdrivers/mmc/card/sdio_uart.c+114 -760 replies
4/6sdio_uart: Fix termios handlingdrivers/mmc/card/sdio_uart.c+0 -60 replies
5/6sdio_uart: Use kfifo instead of the messy circ stuffdrivers/mmc/card/sdio_uart.c+27 -590 replies
6/6sdio_uart: Style fixesdrivers/mmc/card/sdio_uart.c+15 -180 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] Clean up the sdio_uart driver and fix the tty code

This sorts out the sdio uart handling of the tty layer. The existing code has lots of races and other fun bugs. Beat it into the current tty format for hotpluggable devices. The updates are intentionally modelled on Alan Stern's USB serial approach which is defintiely "best practice" right now. Also clean it up as we go and sort the circ stuff out.

I don't have hardware to test this so hopefully someone out there does, otherwise given the nature of the bugs involved the driver will be progressed to BROKEN and removal.
---

Alan Cox (6):
sdio_uart: Style fixes
sdio_uart: Use kfifo instead of the messy circ stuff
sdio_uart: Fix termios handling
sdio_uart: Switch to the open/close helpers
sdio_uart: Move the open lock
sdio_uart: refcount the tty objects

 drivers/mmc/card/sdio_uart.c |  333 ++++++++++++++++++++++--------------------
 1 files changed, 176 insertions(+), 157 deletions(-)
Signature · 1 line
"and on the seventh day she exited append mode"