Skip to content

perf-probe and kprobe-tracer updates

Masami Hiramatsu lkml 1 version In review

Get series with b4
b4 am 20091104001204.3454.75999.stgit@harusame

Versions newest first

  1. v1 Latest5 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5perf/probe: Update Documentation/perf-probe.txttools/perf/Documentation/perf-probe.txt+9 -81 reply
2/5perf/probes: Improve error messagestools/perf/builtin-probe.c tools/perf/util/probe-finder.c+16 -81 reply
3/5perf/probes: Fall back to non-dwarf if possibletools/perf/builtin-probe.c tools/perf/util/probe-finder.c+42 -311 reply
4/5perf/probes: Rename perf probe events group nametools/perf/builtin-probe.c+1 -11 reply
5/5tracing/kprobes: Rename Kprobe-tracer to kprobe-eventDocumentation/trace/kprobetrace.txt kernel/trace/Kconfig kernel/trace/Makefile +1 more+31 -301 reply

Reviews trailers per patch

All 5 patches have a Reviewed-by or Acked-by.

PatchFrederic Weisbecker
1/5A-b
2/5A-b
3/5A-b
4/5A-b
5/5A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH -tip perf/probes 0/5] perf-probe and kprobe-tracer updates

Hi,

Here are some updates according to previous LKML threads.
- Update perf-probe document.
- Improve error messages.
- Fall back to non-dwarf mode if possible.
- Change group name to probe.
- Rename kprobe-tracer to kprobe-event.

BTW, I think perf-probe and kprobe-event might better share similar syntax for not confusing users. And for that purpose, perf-probe syntax should introduce event/group specifier, for example,

perf probe "newgroup:newevnt=func:10 arg1 arg2"

adds the newevent under newgroup. On the other hand, ftrace users can also add a new event as below;

echo 'newgroup:newevent=func+0x18 arg1=$a1 arg2=$a2' > kprobe_events

Any thoughts?

TODO:
- Support --list option to show probes.
- Support --del option to remove probes.
- Simplify probe names.
- Support --line option to show which lines user can probe.
- Support lazy string matching.

Thank you,

---

Masami Hiramatsu (5):
tracing/kprobes: Rename Kprobe-tracer to kprobe-event perf/probes: Rename perf probe events group name perf/probes: Fall back to non-dwarf if possible perf/probes: Improve error messages perf/probe: Update Documentation/perf-probe.txt

 Documentation/trace/kprobetrace.txt     |   34 ++++++-------
 kernel/trace/Kconfig                    |   19 ++++---
 kernel/trace/Makefile                   |    2 -
 kernel/trace/trace_kprobe.c             |    6 +-
 tools/perf/Documentation/perf-probe.txt |   17 +++---
 tools/perf/builtin-probe.c              |   84 ++++++++++++++++++-------------
 tools/perf/util/probe-finder.c          |    7 ++-
 7 files changed, 95 insertions(+), 74 deletions(-)
Signature · 6 lines
Masami Hiramatsu

Software Engineer
Hitachi Computer Products (America), Inc.
Software Solutions Division
e-mail: [email protected]