Skip to content

rewritten rt2800 drivers

Bartlomiej Zolnierkiewicz linux-wireless lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest41 patches 101 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/41rt2800usb: make Kconfig help entry more helpfuldrivers/net/wireless/rt2x00/Kconfig+5 -12 replies
2/41rt2800pci: make Kconfig help entry more helpfuldrivers/net/wireless/rt2x00/Kconfig+4 -14 replies
3/41rt2800usb: fix rt2800usb_rfcsr_read()drivers/net/wireless/rt2x00/rt2800usb.c+1 -12 replies
4/41rt2800pci: fix crypto in TX framedrivers/net/wireless/rt2x00/rt2800pci.c+1 -12 replies
5/41rt2800pci: fix comment about register accessdrivers/net/wireless/rt2x00/rt2800pci.c+3 -12 replies
6/41rt2800pci: fix comment about IV/EIV fieldsdrivers/net/wireless/rt2x00/rt2800pci.c+2 -22 replies
7/41rt2x00: fix rt2x00usb_register_read() commentdrivers/net/wireless/rt2x00/rt2x00usb.h+1 -12 replies
8/41rt2800usb: use rt2x00usb_register_multiwrite() to set key entriesdrivers/net/wireless/rt2x00/rt2800usb.c+4 -142 replies
9/41rt2800usb: add rt2800_register_[read,write]() wrappersdrivers/net/wireless/rt2x00/rt2800usb.c drivers/net/wireless/rt2x00/rt2800usb.h+213 -1922 replies
10/41rt2800pci: add rt2800_register_[read,write]() wrappersdrivers/net/wireless/rt2x00/rt2800pci.c drivers/net/wireless/rt2x00/rt2800pci.h+261 -2394 replies
11/41rt2800usb: add rt2800_register_multi[read,write]() wrappersdrivers/net/wireless/rt2x00/rt2800usb.c drivers/net/wireless/rt2x00/rt2800usb.h+22 -82 replies
12/41rt2800pci: add rt2800_register_multi[read,write]() wrappersdrivers/net/wireless/rt2x00/rt2800pci.c drivers/net/wireless/rt2x00/rt2800pci.h+26 -112 replies
13/41rt2800usb: add rt2800_regbusy_read() wrapperdrivers/net/wireless/rt2x00/rt2800usb.c drivers/net/wireless/rt2x00/rt2800usb.h+13 -54 replies
14/41rt2800pci: add rt2800_regbusy_read() wrapperdrivers/net/wireless/rt2x00/rt2800pci.c drivers/net/wireless/rt2x00/rt2800pci.h+14 -62 replies
15/41rt2800usb: add rt2800_bbp_[read,write]() wrappersdrivers/net/wireless/rt2x00/rt2800usb.c+75 -632 replies
16/41rt2800pci: add rt2800_bbp_[read,write]() wrappersdrivers/net/wireless/rt2x00/rt2800pci.c+75 -632 replies
17/41rt2800usb: add rt2800_rfcsr_[read,write]() wrappersdrivers/net/wireless/rt2x00/rt2800usb.c+53 -412 replies
18/41rt2800pci: add rt2800_rfcsr_[read,write]() wrappersdrivers/net/wireless/rt2x00/rt2800pci.c+63 -512 replies
19/41rt2800usb: add rt2800_rf_[read,write]() wrappersdrivers/net/wireless/rt2x00/rt2800usb.c+19 -132 replies
20/41rt2800pci: add rt2800_rf_[read,write]() wrappersdrivers/net/wireless/rt2x00/rt2800pci.c+19 -132 replies
21/41rt2800usb: add rt2800_mcu_request() wrapperdrivers/net/wireless/rt2x00/rt2800usb.c+17 -102 replies
22/41rt2800pci: add rt2800_mcu_request() wrapperdrivers/net/wireless/rt2x00/rt2800pci.c+16 -92 replies
23/41rt2x00: add driver private field to struct rt2x00_devdrivers/net/wireless/rt2x00/rt2x00.h+5 -05 replies
24/41rt2800usb: convert to use struct rt2800_ops methodsdrivers/net/wireless/rt2x00/rt2800usb.c drivers/net/wireless/rt2x00/rt2800usb.h+51 -63 replies
25/41rt2800pci: convert to use struct rt2800_ops methodsdrivers/net/wireless/rt2x00/rt2800pci.c drivers/net/wireless/rt2x00/rt2800pci.h+51 -62 replies
26/41rt2x00: fix rt2x00usb_register_multiwrite() argumentsdrivers/net/wireless/rt2x00/rt2800usb.h drivers/net/wireless/rt2x00/rt2x00usb.h+5 -42 replies
27/41rt2x00: fix rt2x00usb_regbusy_read() argumentsdrivers/net/wireless/rt2x00/rt2800usb.h drivers/net/wireless/rt2x00/rt2x00usb.c drivers/net/wireless/rt2x00/rt2x00usb.h+3 -32 replies
28/41rt2x00: fix rt2x00pci_register_multi[read,write]() argumentsdrivers/net/wireless/rt2x00/rt2800pci.h drivers/net/wireless/rt2x00/rt2x00pci.h+11 -122 replies
29/41rt2800: add rt2800lib.hdrivers/net/wireless/rt2x00/rt2800lib.h drivers/net/wireless/rt2x00/rt2800pci.c drivers/net/wireless/rt2x00/rt2800pci.h +2 more+101 -1512 replies
30/41rt2800usb: fix comments in rt2800usb.hdrivers/net/wireless/rt2x00/rt2800usb.h+8 -82 replies
31/41rt2800usb: add RXINFO_DESC_SIZE definitiondrivers/net/wireless/rt2x00/rt2800usb.c drivers/net/wireless/rt2x00/rt2800usb.h+4 -32 replies
32/41rt2800: fix duplication in header filesdrivers/net/wireless/rt2x00/rt2800.h drivers/net/wireless/rt2x00/rt2800pci.c drivers/net/wireless/rt2x00/rt2800pci.h +2 more+1881 -36572 replies
33/41rt2800: fix comments in rt2800.hdrivers/net/wireless/rt2x00/rt2800.h+9 -122 replies
34/41rt2x00: add support for different chipset interfacesdrivers/net/wireless/rt2x00/rt2x00.h+29 -02 replies
35/41rt2800: prepare for rt2800lib additiondrivers/net/wireless/rt2x00/rt2800pci.c drivers/net/wireless/rt2x00/rt2800usb.c+133 -1043 replies
36/41rt2800: add rt2800lib (part one)drivers/net/wireless/rt2x00/Kconfig drivers/net/wireless/rt2x00/Makefile drivers/net/wireless/rt2x00/rt2800lib.c +3 more+264 -4592 replies
37/41rt2x00: remove needless ifdefs from rt2x00leds.hdrivers/net/wireless/rt2x00/rt2x00leds.h+0 -42 replies
38/41rt2800: add rt2800lib (part two)drivers/net/wireless/rt2x00/rt2800lib.c drivers/net/wireless/rt2x00/rt2800lib.h drivers/net/wireless/rt2x00/rt2800pci.c +1 more+887 -16802 replies
39/41rt2x00: move REGISTER_BUSY_* definitions to rt2x00.hdrivers/net/wireless/rt2x00/rt2x00.h drivers/net/wireless/rt2x00/rt2x00pci.h drivers/net/wireless/rt2x00/rt2x00usb.h+9 -152 replies
40/41rt2800: add rt2800lib (part three)drivers/net/wireless/rt2x00/rt2800lib.c drivers/net/wireless/rt2x00/rt2800lib.h drivers/net/wireless/rt2x00/rt2800pci.c +1 more+609 -10572 replies
41/41rt2800: add rt2800lib (part four)drivers/net/wireless/rt2x00/rt2800lib.c drivers/net/wireless/rt2x00/rt2800lib.h drivers/net/wireless/rt2x00/rt2800pci.c +1 more+161 -3132 replies

Reviews trailers per patch

All 41 patches have a Reviewed-by or Acked-by.

PatchGertjan van WingerdeIvo van Doorn
1/41A-b A-b
2/41A-b
3/41A-b A-b
4/41A-b A-b
5/41A-b A-b
6/41A-b A-b
7/41A-b A-b
8/41A-b A-b
9/41A-b A-b
10/41A-b A-b
11/41A-b A-b
12/41A-b A-b
13/41A-b A-b A-b
14/41A-b A-b
15/41A-b A-b
16/41A-b A-b
17/41A-b A-b
18/41A-b A-b
19/41A-b A-b
20/41A-b A-b
21/41A-b A-b
22/41A-b A-b
23/41A-b A-b
24/41A-b A-b
25/41A-b
26/41A-b A-b
27/41A-b A-b
28/41A-b A-b
29/41A-b A-b
30/41A-b A-b
31/41A-b A-b
32/41A-b A-b
33/41A-b A-b
34/41A-b A-b
35/41A-b A-b
36/41A-b A-b
37/41A-b A-b
38/41A-b A-b
39/41A-b A-b
40/41A-b A-b
41/41A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/41] rewritten rt2800 drivers

Hi,

Here is the rt2800 rewrite in the form of patches (I've trimmed cc:
list considerably since I'm not sure whether most people really want to see 40+ patches in their mailboxes).

There were some minor changes since yesterday:

- two new patches were added at the top of tree fixing Kconfig help entries of rt2800[pci,usb] drivers to be more helpful and to prevent wasting people's time (I think that patch #1 should go to Linus' tree as soon as possible, ditto for patch #2 and net-next tree)

- patch descriptions were improved for many patches (suggestion from Ingo)

- rt2x00_intf_is_[pci,usb]() helpers for commonly used checks were added to "rt2x00: add support for different chipset interfaces" patch (suggestion from Ivo)

- addition of separate rt2800 MAINTAINERS entry was dropped for now because it stirred needless controversies distracting people from technical issues (thanks to Julian Calaby for pointing this to me), the goal of change was to make sure that people won't bother busy rt2x00 maintainers about rt2800 tree so it is not a big deal anyway

The rt2800 tree has also been updated to reflect those changes (old branch is still available as rt2800-v1 for reference):

The following changes since commit fa867e7355a1bdcd9bf7d55ebe9296f5b9c4028a:
Juuso Oikarinen (1):
wl1271: Generalize command response reading

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/bart/misc.git rt2800

Bartlomiej Zolnierkiewicz (41):

      rt2800usb: make Kconfig help entry more helpful
      rt2800pci: make Kconfig help entry more helpful
      rt2800usb: fix rt2800usb_rfcsr_read()
      rt2800pci: fix crypto in TX frame
      rt2800pci: fix comment about register access
      rt2800pci: fix comment about IV/EIV fields
      rt2x00: fix rt2x00usb_register_read() comment
      rt2800usb: use rt2x00usb_register_multiwrite() to set key entries
      rt2800usb: add rt2800_register_[read,write]() wrappers
      rt2800pci: add rt2800_register_[read,write]() wrappers
      rt2800usb: add rt2800_register_multi[read,write]() wrappers
      rt2800pci: add rt2800_register_multi[read,write]() wrappers
      rt2800usb: add rt2800_regbusy_read() wrapper
      rt2800pci: add rt2800_regbusy_read() wrapper
      rt2800usb: add rt2800_bbp_[read,write]() wrappers
      rt2800pci: add rt2800_bbp_[read,write]() wrappers
      rt2800usb: add rt2800_rfcsr_[read,write]() wrappers
      rt2800pci: add rt2800_rfcsr_[read,write]() wrappers
      rt2800usb: add rt2800_rf_[read,write]() wrappers
      rt2800pci: add rt2800_rf_[read,write]() wrappers
      rt2800usb: add rt2800_mcu_request() wrapper
      rt2800pci: add rt2800_mcu_request() wrapper
      rt2x00: add driver private field to struct rt2x00_dev
      rt2800usb: convert to use struct rt2800_ops methods
      rt2800pci: convert to use struct rt2800_ops methods
      rt2x00: fix rt2x00usb_register_multiwrite() arguments
      rt2x00: fix rt2x00usb_regbusy_read() arguments
      rt2x00: fix rt2x00pci_register_multi[read,write]() arguments
      rt2800: add rt2800lib.h
      rt2800usb: fix comments in rt2800usb.h
      rt2800usb: add RXINFO_DESC_SIZE definition
      rt2800: fix duplication in header files
      rt2800: fix comments in rt2800.h
      rt2x00: add support for different chipset interfaces
      rt2800: prepare for rt2800lib addition
      rt2800: add rt2800lib (part one)
      rt2x00: remove needless ifdefs from rt2x00leds.h
      rt2800: add rt2800lib (part two)
      rt2x00: move REGISTER_BUSY_* definitions to rt2x00.h
      rt2800: add rt2800lib (part three)
      rt2800: add rt2800lib (part four)
 drivers/net/wireless/rt2x00/Kconfig      |   16 +-
 drivers/net/wireless/rt2x00/Makefile     |    1 +
 drivers/net/wireless/rt2x00/rt2800.h     | 1816 ++++++++++++++++++++++++++++
 drivers/net/wireless/rt2x00/rt2800lib.c  | 1817 ++++++++++++++++++++++++++++
 drivers/net/wireless/rt2x00/rt2800lib.h  |  134 +++
 drivers/net/wireless/rt2x00/rt2800pci.c  | 1908 +++---------------------------
 drivers/net/wireless/rt2x00/rt2800pci.h  | 1780 ----------------------------
 drivers/net/wireless/rt2x00/rt2800usb.c  | 1828 ++---------------------------
 drivers/net/wireless/rt2x00/rt2800usb.h  | 1818 +----------------------------
 drivers/net/wireless/rt2x00/rt2x00.h     |   43 +
 drivers/net/wireless/rt2x00/rt2x00leds.h |    4 -
 drivers/net/wireless/rt2x00/rt2x00pci.h  |   24 +-
 drivers/net/wireless/rt2x00/rt2x00usb.c  |    2 +-
 drivers/net/wireless/rt2x00/rt2x00usb.h  |   17 +-
 14 files changed, 4048 insertions(+), 7160 deletions(-)
 create mode 100644 drivers/net/wireless/rt2x00/rt2800.h
 create mode 100644 drivers/net/wireless/rt2x00/rt2800lib.c
 create mode 100644 drivers/net/wireless/rt2x00/rt2800lib.h