Skip to content

btrfs: Error handling/propagation queue

Jeff Mahoney linux-btrfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10btrfs: fix btrfs_read_block_groups return valuefs/btrfs/extent-tree.c+6 -60 replies
2/10btrfs: fix memleak in btrfs_init_new_devicefs/btrfs/volumes.c+1 -00 replies
3/10btrfs: fix btrfs_read_fs_root* return valuesfs/btrfs/disk-io.c fs/btrfs/extent-tree.c fs/btrfs/tree-log.c+8 -60 replies
4/10btrfs: btrfs_sync_file should return -EIO not EIOfs/btrfs/file.c+1 -10 replies
5/10btrfs: Add BTRFS_UERROR for unhandled errorsfs/btrfs/ctree.h fs/btrfs/super.c+16 -00 replies
6/10btrfs: annotate kmalloc failuresfs/btrfs/compression.c fs/btrfs/ctree.c fs/btrfs/disk-io.c +8 more+33 -150 replies
7/10btrfs: handle kmalloc call path failuresfs/btrfs/compression.c fs/btrfs/disk-io.c fs/btrfs/extent-tree.c +6 more+74 -360 replies
8/10btrfs: annotate btrfs_{start,join}_transaction failuresfs/btrfs/disk-io.c fs/btrfs/extent-tree.c fs/btrfs/file.c +8 more+58 -140 replies
9/10btrfs: handle btrfs_{start,join}_transaction call path failuresfs/btrfs/compression.c fs/btrfs/disk-io.c fs/btrfs/extent-tree.c +10 more+382 -1880 replies
10/10btrfs: annotate btrfs_alloc_path failuresfs/btrfs/ctree.c fs/btrfs/dir-item.c fs/btrfs/disk-io.c +9 more+42 -320 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 00/10] btrfs: Error handling/propagation queue

This patch series fixes a few existing problems and then addresses the need for better error handling and propagation in btrfs.

The handling and propagation patch set first finds all locations of a particular condition not being checked and annotates them with BTRFS_UERROR to designate that there is an error condition that is currently unhandled but should be. Then, another patch traverses the call path to ensure that errors are properly propogated. When the fix for recovering or passing the error is obvious, we do that too.

This set is not complete and I expect there to be more fixes coming. In particular, it currently only annotates btrfs_alloc_path failures as the call graph for it is quite large. This is in response to Chris asking for what I already have instead of waiting for it to be complete.

-Jeff

Signature · 2 lines
Jeff Mahoney
SUSE Labs