Fixups to MPC5200 ASoC drivers
Get series with b4
b4 am 20091107081631.18908.82921.stgit@anguaVersions newest first
- v1 Latest6 patches 23 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/6 | ASoC/mpc5200: Track DMA position by period number instead of bytessound/ sound/ | +11 | 2 replies | |
| 2/6 | ASoC/mpc5200: get rid of the appl_ptr tracking nonsensesound/ sound/ | +8 | 14 replies | |
| 3/6 | ASoC/mpc5200: Improve printk debug output for triggersound/ sound/ | +11 | 0 replies | |
| 4/6 | ASoC/mpc5200: add to_psc_dma_stream() helpersound/ sound/ | +10 | 1 reply | |
| 5/6 | ASoC/mpc5200: fix enable/disable of AC97 slotssound/ sound/ | +25 | 0 replies | |
| 6/6 | ASoC/mpc5200: Add fudge factor to value reported by .pointer()sound/ | +1 | 4 replies |
Reviews trailers per patch
1 of 6 patches has a Reviewed-by or Acked-by.
| Patch | Liam Girdwood |
|---|---|
| 1/6 | A-b |
| 2/6 | |
| 3/6 | |
| 4/6 | |
| 5/6 | |
| 6/6 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/6] Fixups to MPC5200 ASoC drivers
Hi everyone,
Jon, as we talked about earlier today, I've spent some time working on the MPC5200 AC97 driver to try and get rid of some of the nagging bugs. The two big changes that I ended up making were to remove the tracking of appl_ptr (and all the race conditions that went with it), and to fix the handling of AC97 slot enables/disables so that a stream can be stopped and started again without going through the hw_params() step.
I know that you had the appl_ptr tracking in to try and solve the problem of audible noise at the end of playback. After discussing the data flow model on #alsa-soc this morning, I learned that the driver is really supposed to be free-running, and the ALSA layer is supposed to be able to keep up. It is also responsible to ensure that buffer is filled with silence at the end of playback to eliminate noise before the trigger can properly turn everything off. Only a couple of other drivers use appl_ptr, so I'm pretty sure this driver shouldn't be doing it either.
Instead, from a recommendation this morning, I added a 'fudge' factor to the value reported by the .pointer() callback of 1/4 the period size. At first I thought this helped, but after more testing I find that the driver seems to work correctly with aplay both with and without the fudge factor applied.
However, I was able to reproduce the noise problem when using aplay if I have DEBUG #defined at the top of the mpc5200_dma.c file with debug console logs being spit out the serial port. In that situation, the STOP trigger calls printk(), and a stale sample can be heard at the end of playback. However, I believe this is a bug with the serial console driver (in that it disables IRQs for a long time) causing unbounded latencies, so the trigger doesn't get processed fast enough. It doesn't help that aplay doesn't flush the buffers with silence before triggering STOP. Other programs (like gstreamer) do seem to flush out stale data before stopping the stream. I'm sure someone will correct me if I'm making some bad assumptions here.
So, please test. Let me know if these work or not. I've don't know if the last patch (Add fudge factor...) is needed or not.
Cheers,
g.
---
Grant Likely (6):
ASoC/mpc5200: Add fudge factor to value reported by .pointer() ASoC/mpc5200: fix enable/disable of AC97 slots ASoC/mpc5200: add to_psc_dma_stream() helper ASoC/mpc5200: Improve printk debug output for trigger ASoC/mpc5200: get rid of the appl_ptr tracking nonsense ASoC/mpc5200: Track DMA position by period number instead of bytes
sound/soc/fsl/mpc5200_dma.c | 98 ++++++++++---------------------------- sound/soc/fsl/mpc5200_dma.h | 24 ++++++--- sound/soc/fsl/mpc5200_psc_ac97.c | 39 ++++++++------- 3 files changed, 63 insertions(+), 98 deletions(-)
Signature · 1 line
Signature