Skip to content

x86, ucode-amd: trim verbosity

Andreas Herrmann lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 7 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3x86, ucode-amd: Load ucode-patches once and not separately fo each CPUarch/x86/include/asm/microcode.h arch/x86/kernel/microcode_amd.c arch/x86/kernel/microcode_core.c+25 -75 replies
2/3x86, ucode-amd: Don't warn when no ucode is available for a CPU revisionarch/x86/kernel/microcode_amd.c+1 -41 reply
3/3x86, ucode-amd: printk(KERN_* to pr_* conversionarch/x86/kernel/microcode_amd.c+15 -191 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] x86, ucode-amd: trim verbosity

Following patches make log messages of microcode_amd more terse.

Especially in conjunction with Dmitry's planned changes to summarize patch level information this will help to trim messages to the necessary minimum on systems with many CPUs.

Example (without patch 1 and 2) of a 48 CPU system:

microcode: CPU0: patch_level=0x10000b5
platform microcode: firmware: requesting amd-ucode/microcode_amd.bin
microcode: CPU0: cpu revision not listed in equivalent cpu table
microcode: CPU0: cpu revision not listed in equivalent cpu table
microcode: CPU1: patch_level=0x10000b5
platform microcode: firmware: requesting amd-ucode/microcode_amd.bin
microcode: CPU1: cpu revision not listed in equivalent cpu table
microcode: CPU1: cpu revision not listed in equivalent cpu table

...

microcode: CPU46: patch_level=0x10000b5
platform microcode: firmware: requesting amd-ucode/microcode_amd.bin
microcode: CPU46: cpu revision not listed in equivalent cpu table
microcode: CPU46: cpu revision not listed in equivalent cpu table
microcode: CPU47: patch_level=0x10000b5
platform microcode: firmware: requesting amd-ucode/microcode_amd.bin
microcode: CPU47: cpu revision not listed in equivalent cpu table
microcode: CPU47: cpu revision not listed in equivalent cpu table Microcode Update Driver: v2.00 <[email protected]>, Peter Oruba

This is a lot of unnecessary noise. With patches 1 and 2 applied this is shortened to:

platform microcode: firmware: requesting amd-ucode/microcode_amd.bin
microcode: CPU0: patch_level=0x10000b5
microcode: CPU1: patch_level=0x10000b5

...

microcode: CPU46: patch_level=0x10000b5
microcode: CPU47: patch_level=0x10000b5
Microcode Update Driver: v2.00 <[email protected]>, Peter Oruba

And with Dmitry's patches this will be trimmed down even further.
Note: Patch 3 is just a conversion from printk to pr_ macros.

Patches are against tip/master.
Please apply.

Thanks,

Andreas