Skip to content

IPMI devices from ACPI namespace

Bjorn Helgaas linux-acpi 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 13 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5PNPACPI: save struct acpi_device, not just acpi_handledrivers/pnp/pnpacpi/core.c drivers/pnp/pnpacpi/rsparser.c+18 -80 replies
2/5PNP: add interface to retrieve ACPI device from a PNPACPI devicedrivers/pnp/pnpacpi/core.c include/linux/pnp.h+14 -10 replies
3/5ipmi: remove unused PCI probe codedrivers/char/ipmi/ipmi_si_intf.c+0 -47 replies
4/5ipmi: refer to table as "SPMI", not "ACPI"drivers/char/ipmi/ipmi_si_intf.c+5 -50 replies
5/5ipmi: add PNP discovery (ACPI namespace via PNPACPI)drivers/char/ipmi/ipmi_si_intf.c+104 -01 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH v1 0/5] IPMI devices from ACPI namespace

Here's a sample of how I think the ACPI namespace device detection should be done. I think this is almost functionally equivalent to your "Locate the IPMI system interface in ACPI namespace" patch.

The difference I'm aware of is that your patch doesn't call acpi_register_gsi() for IRQs from the device _CRS, so I don't think those interrupts would work. (I can't test this because I don't have a box that reports an IRQ in _CRS.) PNPACPI takes care of this GSI registration for us.

Patches 3 & 4 are not really related to the main point here, but I left them in because without 4, we'll report both SPMI and ACPI namespace devices as being from "ACPI".

---

Bjorn Helgaas (5):
PNPACPI: save struct acpi_device, not just acpi_handle
PNP: add interface to retrieve ACPI device from a PNPACPI device
ipmi: remove unused PCI probe code
ipmi: refer to table as "SPMI", not "ACPI"
ipmi: add PNP discovery (ACPI namespace via PNPACPI)

 drivers/char/ipmi/ipmi_si_intf.c |  118 +++++++++++++++++++++++++++++++++++---
 drivers/pnp/pnpacpi/core.c       |   19 ++++--
 drivers/pnp/pnpacpi/rsparser.c   |    9 ++-
 include/linux/pnp.h              |   13 ++++
 4 files changed, 141 insertions(+), 18 deletions(-)
Signature · 1 line
Bjorn