Skip to content

PNX clock API fixes

Russell King - ARM Linux linux-arm-kernel linux-i2c 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest10 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10ARM: PNX4008: convert to clkdevarch/arm/Kconfig arch/arm/mach-pnx4008/clock.c arch/arm/mach-pnx4008/clock.h +1 more+46 -330 replies
2/10ARM: PNX4008: simplify clk enable/disable pathsarch/arm/mach-pnx4008/clock.c+23 -320 replies
3/10ARM: PNX4008: provide clock enable/disable methods and initializationarch/arm/mach-pnx4008/clock.c arch/arm/mach-pnx4008/clock.h+26 -130 replies
4/10ARM: PNX4008: convert watchdog clocks to match by device onlyarch/arm/mach-pnx4008/clock.c drivers/watchdog/pnx4008_wdt.c+2 -21 reply
4/10ARM: PNX4008: convert watchdog clocks to match by device only+0 -00 replies
5/10ARM: PNX4008: convert watchdog to use clk API enable/disable callsarch/arm/mach-pnx4008/clock.c drivers/watchdog/pnx4008_wdt.c+26 -152 replies
5/10ARM: PNX4008: convert watchdog to use clk API enable/disable calls+0 -00 replies
6/10ARM: PNX4008: convert i2c clocks to match by device onlyarch/arm/mach-pnx4008/clock.c arch/arm/mach-pnx4008/i2c.c+5 -90 replies
7/10ARM: PNX4008: move i2c suspend/resume callbacks into driverarch/arm/mach-pnx4008/i2c.c drivers/i2c/busses/i2c-pnx.c include/linux/i2c-pnx.h+7 -301 reply
7/10ARM: PNX4008: move i2c suspend/resume callbacks into driver+0 -01 reply
7/10ARM: PNX4008: move i2c suspend/resume callbacks into driver+0 -02 replies
7/10ARM: PNX4008: move i2c suspend/resume callbacks into driver+0 -01 reply
8/10ARM: PNX4008: move i2c clock start/stop into driverarch/arm/mach-pnx4008/i2c.c drivers/i2c/busses/i2c-pnx.c include/linux/i2c-pnx.h+32 -470 replies
9/10ARM: PNX4008: convert i2c-pnx to use clk API enable/disable callsarch/arm/mach-pnx4008/clock.c drivers/i2c/busses/i2c-pnx.c+15 -150 replies
10/10ARM: PNX4008: get i2c clock rate from clk APIarch/arm/mach-pnx4008/clock.c arch/arm/mach-pnx4008/i2c.c drivers/i2c/busses/i2c-pnx.c +1 more+10 -240 replies

Reviews trailers per patch

4 of 15 patches have a Reviewed-by or Acked-by.

PatchWim Van Sebroeck
1/10
2/10
3/10
4/10A-b
4/10A-b
5/10A-b
5/10A-b
6/10
7/10
7/10
7/10
7/10
8/10
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/10] PNX clock API fixes

Following on from the previous set of patches...

The PNX4008 clock API usage is extremely poor. Nothing works as it was intended to - clk_set_rate() is used to turn clocks on and off, or set dividers. I certainly doesn't take the desired clock rate in Hz. clk_get_rate() doesn't report the clock rate in Hz either - it doesn't even report any kind of rate.

clk_enable and clk_disable seem to be very weird too.

This patch set fixes the I2C and watchdog drivers so that they can be used with clk API implementations which do actually conform with the clk API.

As per the previous set, selective cc's. Full set will be on linux-arm-kernel.