Skip to content

via-velocity performance fixes

Simon Kagstrom netdev 3 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v4 Latest7 patches 1 replyIn review
  2. v27 patches 4 repliesSuperseded
  3. v17 patches 7 repliesSuperseded

Patches in v4 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7via-velocity: Correct 64-byte alignment for rx buffersdrivers/net/via-velocity.c+2 -10 replies
2/7via-velocity: Add ethtool interrupt coalescing supportdrivers/net/via-velocity.c drivers/net/via-velocity.h+165 -20 replies
3/7via-velocity: Implement NAPI supportdrivers/net/via-velocity.c drivers/net/via-velocity.h+49 -350 replies
4/7via-velocity: Change DMA_LENGTH_DEF (from the VIA driver)drivers/net/via-velocity.c+1 -10 replies
5/7via-velocity: Re-enable transmit scatter-gather supportdrivers/net/via-velocity.c+53 -300 replies
6/7via-velocity: Set tx checksum from ethtool instead of module parameterdrivers/net/via-velocity.c drivers/net/via-velocity.h+4 -150 replies
7/7via-velocity: Bump versiondrivers/net/via-velocity.h+1 -10 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v4 yet.

Read the v4 thread

Cover letter [PATCH v4 0/7] via-velocity performance fixes

Hi again!

This is version four of the series posted here:

http://marc.info/?l=linux-netdev&m=125873023117769&w=2

The new version integrates Davids comments. There are 7 patches:

1. See to it that data is 64-byte aligned (same as before)

2. Add ethtool interrupt coalescing support. (same as before)

3. NAPI support for via-velocity (same as before)

4. Change DMA length default (same as before)

5. Re-enable scatter-gather support. (removed the double-check of nr_frags according to Davids comment)

6. Set tx checksum from ethtool instead of a module parameter (rebased)

7. Bump the version.

To get the same performance results (or better!) as with the VIA driver, you now need to setup interrupt supression with

ethtool -C ethX rx-usecs 20 tx-usecs 100 tx-frames 31 rx-frames 31

(which are the defaults from the VIA driver). Scatter-gather support is enabled with

ethtool -K ethX sg on

// Simon