Skip to content

cfq-iosched: policy fixes

Corrado Zoccolo lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest4 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4cfq-iosched: fix ncq detection codeblock/cfq-iosched.c+15 -90 replies
2/4cfq-iosched: fix no-idle preemption logicblock/cfq-iosched.c+3 -21 reply
3/4cfq-iosched: idling on deep seeky sync queuesblock/cfq-iosched.c+12 -13 replies
4/4cfq-iosched: fix corner cases in idling logicblock/cfq-iosched.c+22 -107 replies

Reviews trailers per patch

2 of 4 patches have a Reviewed-by or Acked-by.

PatchVivek Goyal
1/4
2/4A-b
3/4
4/4A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/4] cfq-iosched: policy fixes

Hi Jens,
I've collected some bugfixes to the for-2.6.33 branch. Excluding the NCQ policy fix, that I'm resending with improved changelog, the bugs were found by Vivek while investingating performance drops or unfairness while testing cgroups. Nevertheless, those fixes have general impact, so they should go in before cgroup code is merged:
* no-idle preemption logic was both under/over preempting.
it should preempt only if the active queue is idling due to no-idle service tree empty
* seeky queues with large depth could steal too much bandwidth to low depth ones, so they will be marked as idling, and have exclusive access to disk for their time share
* the idling logic had some corner cases in which idling was not enabled, even if it should have been, caused by rq_noidle and rq_in_driver checks. Those were adjusted to better match the original intention.

Corrado