Skip to content

RFC Remove skb_dma_map/unmap calls

Alexander Duyck netdev 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 RFC Latest10 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/10e1000e: remove use of skb_dma_map from e1000e driverdrivers/net/e1000e/e1000.h drivers/net/e1000e/netdev.c+47 -210 replies
2/10e1000: remove use of skb_dma_map from e1000 driverdrivers/net/e1000/e1000.h drivers/net/e1000/e1000_main.c+41 -160 replies
3/10ixgb: remove use of skb_dma_map from ixgbdrivers/net/ixgb/ixgb.h drivers/net/ixgb/ixgb_main.c+42 -190 replies
4/10ixgbe: remove skb_dma_map/unmap calls from driverdrivers/net/ixgbe/ixgbe.h drivers/net/ixgbe/ixgbe_main.c+50 -140 replies
5/10igb: remove use of skb_dma_map from driverdrivers/net/igb/igb.h drivers/net/igb/igb_main.c+56 -180 replies
6/10igbvf: remove skb_dma_map/unmap call from driversdrivers/net/igbvf/igbvf.h drivers/net/igbvf/netdev.c+52 -140 replies
7/10bnx2: remove skb_dma_map/unmap calls from driverdrivers/net/bnx2.c drivers/net/bnx2.h+62 -132 replies
8/10be2net: remove use of skb_dma_map/unmapdrivers/net/benet/be_main.c+26 -111 reply
9/10tg3: remove use of skb_dma_map/unmapdrivers/net/tg3.c drivers/net/tg3.h+132 -470 replies
10/10skbuff: remove skb_dma_map/unmapinclude/linux/skbuff.h net/core/Makefile net/core/skb_dma_map.c+0 -740 replies

Reviews trailers per patch

1 of 10 patches has a Reviewed-by or Acked-by.

PatchAjit Khaparde
1/10
2/10
3/10
4/10
5/10
6/10
7/10
8/10A-b
9/10
10/10

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [RFC PATCH 00/10] Remove skb_dma_map/unmap calls

This patch series removes the skb_dma_map and skb_dma_unmap function calls. The reason for this change is because the use of skb_dma_map/unmap can lead to serious issues when HW IOMMU is enabled. This is because each mapping of the skb with a HW IOMMU enabled results in a new set of DMA mappings. This in turn leads to issues when skbs are cloned for uses such as bridging or pktgen because each transmitting device will update the skb shared info structure resulting in some mappings being overwritten, and others being freed multiple times.

I am looking for input specifically on the tg3, be2net, and bnx2 driver patches as I am not very familiar with them and I am not certain if additional changes are required.

I have included the changes for the Intel wired Ethernet drivers as a reference.

---

Alexander Duyck (10):
skbuff: remove skb_dma_map/unmap
tg3: remove use of skb_dma_map/unmap
be2net: remove use of skb_dma_map/unmap
bnx2: remove skb_dma_map/unmap calls from driver
igbvf: remove skb_dma_map/unmap call from drivers
igb: remove use of skb_dma_map from driver
ixgbe: remove skb_dma_map/unmap calls from driver
ixgb: remove use of skb_dma_map from ixgb
e1000: remove use of skb_dma_map from e1000 driver
e1000e: remove use of skb_dma_map from e1000e driver

 drivers/net/benet/be_main.c    |   37 ++++++---
 drivers/net/bnx2.c             |   74 ++++++++++++++---
 drivers/net/bnx2.h             |    1 
 drivers/net/e1000/e1000.h      |    1 
 drivers/net/e1000/e1000_main.c |   56 +++++++++----
 drivers/net/e1000e/e1000.h     |    9 +-
 drivers/net/e1000e/netdev.c    |   59 +++++++++-----
 drivers/net/igb/igb.h          |    5 +
 drivers/net/igb/igb_main.c     |   69 ++++++++++++----
 drivers/net/igbvf/igbvf.h      |    1 
 drivers/net/igbvf/netdev.c     |   65 ++++++++++++---
 drivers/net/ixgb/ixgb.h        |    1 
 drivers/net/ixgb/ixgb_main.c   |   60 +++++++++-----
 drivers/net/ixgbe/ixgbe.h      |    1 
 drivers/net/ixgbe/ixgbe_main.c |   63 +++++++++++----
 drivers/net/tg3.c              |  173 ++++++++++++++++++++++++++++++----------
 drivers/net/tg3.h              |    6 -
 include/linux/skbuff.h         |    8 --
 net/core/Makefile              |    1 
 net/core/skb_dma_map.c         |   65 ---------------
 20 files changed, 508 insertions(+), 247 deletions(-)
 delete mode 100644 net/core/skb_dma_map.c