Skip to content

OMAP clock: convert static definitions in header files to C files

Paul Walmsley linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest8 patches 0 repliesNew

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8OMAP1/2/3 clock: remove paranoid checks in preparation for clock{, 2xxx, 3xxx}_data.carch/arm/mach-omap1/clock.c arch/arm/mach-omap2/clock24xx.c arch/arm/mach-omap2/clock34xx.c+0 -300 replies
2/8OMAP2 clock: APLL code shouldn't rely on static clocks in its local namespacearch/arm/mach-omap2/clock24xx.c arch/arm/mach-omap2/clock24xx.h+25 -140 replies
3/8OMAP2/3: move SDRC macros to mach-omap2/sdrc.harch/arm/mach-omap2/clock34xx.c arch/arm/mach-omap2/sdrc.h+16 -140 replies
4/8OMAP2xxx clock: remove implicit dependency between rate CPU flag and clkdev_omap CPU flagarch/arm/mach-omap2/clock24xx.c+4 -10 replies
5/8OMAP3 clock: convert clock34xx.h to clock34xx_data.carch/arm/mach-omap2/Makefile arch/arm/mach-omap2/clock.h arch/arm/mach-omap2/clock24xx.c +4 more+464 -34120 replies
6/8OMAP2 clock: convert clock24xx.h to clock2xxx_data.c, opp2xxx*arch/arm/mach-omap2/Makefile arch/arm/mach-omap2/clock.h arch/arm/mach-omap2/clock24xx.c +9 more+1610 -13970 replies
7/8OMAP1 clock: convert test in disable_unused() to use ENABLE_ON_INITarch/arm/mach-omap1/clock.c arch/arm/mach-omap1/clock.h+16 -120 replies
8/8OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.carch/arm/mach-omap1/Makefile arch/arm/mach-omap1/clock.c arch/arm/mach-omap1/clock.h +5 more+496 -11122 replies
8/8OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c+0 -01 reply
8/8OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c+0 -01 reply
8/8OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c+0 -010 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/8] OMAP clock: convert static definitions in header files to C files

The OMAP clock code has traditionally defined its clock nodes statically in header files (e.g., mach-omap1/clock.h). This violates the general guideline that including a header file should be side-effect free, or at least as side-effect free as possible. This series moves all of the statically-allocated data from header files into C files that are linked into kernels. It moves OPP data (or at least the proto-OPP data in OMAP1 and OMAP2xxx) into separate files. It also resolves all of the checkpatch errors that appear as a result of the move.

This series has been boot-tested on OMAP1 (on a 5912 OSK), OMAP2 (on N800 and 2430 SDP), and OMAP3 (BeagleBoard).

This series was prompted by a comment from Russell King <[email protected]>, who suggested the basic layout that these patches implement.

- Paul

---

size:
text data bss dec hex filename
3582959 199264 107176 3889399 3b58f7 vmlinux.beagle.orig
3583063 199264 107176 3889503 3b595f vmlinux.beagle

Paul Walmsley (8):
OMAP1/2/3 clock: remove paranoid checks in preparation for clock{,2xxx,3xxx}_data.c OMAP2 clock: APLL code shouldn't rely on static clocks in its local namespace OMAP2/3: move SDRC macros to mach-omap2/sdrc.h
OMAP2xxx clock: remove implicit dependency between rate CPU flag and clkdev_omap CPU flag OMAP3 clock: convert clock34xx.h to clock34xx_data.c
OMAP2 clock: convert clock24xx.h to clock2xxx_data.c, opp2xxx*
OMAP1 clock: convert test in disable_unused() to use ENABLE_ON_INIT
OMAP1 clock: convert mach-omap1/clock.h to mach-omap1/clock_data.c

 arch/arm/mach-omap1/Makefile                  |    3 
 arch/arm/mach-omap1/clock.c                   |  415 ---
 arch/arm/mach-omap1/clock.h                   |  652 -----
 arch/arm/mach-omap1/clock_data.c              |  443 +++-
 arch/arm/mach-omap1/io.c                      |    3 
 arch/arm/mach-omap1/opp.h                     |   28 
 arch/arm/mach-omap1/opp_data.c                |   59 
 arch/arm/mach-omap2/Makefile                  |    8 
 arch/arm/mach-omap2/clock.h                   |   30 
 arch/arm/mach-omap2/clock24xx.c               |  805 -------
 arch/arm/mach-omap2/clock2xxx.c               |  564 +++++
 arch/arm/mach-omap2/clock2xxx.h               |   44 
 arch/arm/mach-omap2/clock2xxx_data.c          |  844 ++-----
 arch/arm/mach-omap2/clock34xx.c               |  471 ----
 arch/arm/mach-omap2/clock34xx.h               | 3013 -------------------------
 arch/arm/mach-omap2/clock34xx_data.c          |  364 +++
 arch/arm/mach-omap2/clock_common_data.c       |   39 
 arch/arm/mach-omap2/opp2420_data.c            |  126 +
 arch/arm/mach-omap2/opp2430_data.c            |  133 +
 arch/arm/mach-omap2/opp2xxx.h                 |  424 ++++
 arch/arm/mach-omap2/sdrc.h                    |   19 
 arch/arm/plat-omap/include/plat/clkdev_omap.h |   41 
 arch/arm/plat-omap/include/plat/clock.h       |    2 
 23 files changed, 2592 insertions(+), 5938 deletions(-)
 copy arch/arm/mach-omap1/{clock.h => clock_data.c} (58%)
 create mode 100644 arch/arm/mach-omap1/opp.h
 create mode 100644 arch/arm/mach-omap1/opp_data.c
 delete mode 100644 arch/arm/mach-omap2/clock24xx.c
 create mode 100644 arch/arm/mach-omap2/clock2xxx.c
 create mode 100644 arch/arm/mach-omap2/clock2xxx.h
 rename arch/arm/mach-omap2/{clock24xx.h => clock2xxx_data.c} (73%)
 copy arch/arm/mach-omap2/{clock34xx.h => clock34xx_data.c} (86%)
 create mode 100644 arch/arm/mach-omap2/clock_common_data.c
 create mode 100644 arch/arm/mach-omap2/opp2420_data.c
 create mode 100644 arch/arm/mach-omap2/opp2430_data.c
 create mode 100644 arch/arm/mach-omap2/opp2xxx.h
 create mode 100644 arch/arm/plat-omap/include/plat/clkdev_omap.h