Skip to content

ACPI: early _PDC eval and unify x86/ia64

Alex Chiang linux-acpi linux-ia64 lkml 2 versions In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest11 patches 2 repliesIn review
  2. v18 of 11 patches 4 repliesSuperseded

Changes in v2 from the cover letter

- no changes to patches; only fixed mail addresses

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/11ACPI: processor: call _PDC earlydrivers/acpi/Makefile drivers/acpi/bus.c drivers/acpi/internal.h +3 more+115 -692 replies
2/11ACPI: processor: introduce arch_has_acpi_pdcarch/ia64/include/asm/acpi.h arch/x86/include/asm/acpi.h arch/x86/kernel/acpi/processor.c +1 more+13 -30 replies
3/11ACPI: processor: unify arch_acpi_processor_init_pdcarch/ia64/kernel/acpi-processor.c arch/x86/kernel/acpi/processor.c drivers/acpi/processor_pdc.c+46 -670 replies
4/11ACPI: processor: factor out common _PDC settingsarch/ia64/kernel/acpi-processor.c arch/x86/kernel/acpi/processor.c drivers/acpi/processor_pdc.c+13 -180 replies
5/11ACPI: processor: finish unifying arch_acpi_processor_init_pdc()arch/ia64/include/asm/acpi.h arch/ia64/kernel/acpi-processor.c arch/x86/include/asm/acpi.h +3 more+26 -560 replies
6/11ACPI: processor: unify arch_acpi_processor_cleanup_pdcarch/ia64/kernel/Makefile arch/ia64/kernel/acpi-processor.c arch/x86/kernel/acpi/Makefile +3 more+21 -600 replies
7/11ACPI: processor: introduce acpi_processor_alloc_pdc()drivers/acpi/processor_pdc.c+13 -90 replies
8/11ACPI: processor: change acpi_processor_eval_pdc interfacedrivers/acpi/processor_pdc.c+4 -80 replies
9/11ACPI: processor: open code acpi_processor_cleanup_pdcdrivers/acpi/processor_pdc.c+4 -110 replies
10/11ACPI: processor: change acpi_processor_set_pdc() interfacedrivers/acpi/processor_core.c drivers/acpi/processor_pdc.c include/acpi/processor.h+5 -170 replies
11/11ACPI: processor: remove _PDC object list from struct acpi_processorinclude/acpi/processor.h+0 -20 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v2 yet.

Read the v2 thread

Cover letter [PATCH v2 00/11] ACPI: early _PDC eval and unify x86/ia64

Extreme apologies, but I had a mailer hiccup and totally botched the first attempt at mailing this series.

Please disregard that earlier attempt.

v1 -> v2:
- no changes to patches; only fixed mail addresses

It was recently discovered that some BIOS implementations load dynamic SSDTs when a processor's _PDC method is evaluated.

	http://bugzilla.kernel.org/show_bug.cgi?id=14824
	http://bugzilla.kernel.org/show_bug.cgi?id=14710

In Linux, we do not evaluate _PDC until after we initialize the EC.

Unfortunately, that same BIOS references objects in the dynamic table during EC enablement. So we get undefined references to methods during enablement, and we fail to initialize certain pieces of hardware.

Windows works just fine on this machine, so to me, this is a hint that Linux should be evaluating _PDC much earlier.

The first patch in this series does just that and makes Linux more compatible with Windows' ACPI implementation.

The remaining 10 patches unify the x86/ia64 implementations of calling _PDC. I noticed the two archs were way more similar than they were different, so I thought it made sense to combine them as much as possible.

This patch series was built on both x86 and ia64 (checkpatch and sparse clean).

It was also boot tested on an HP Envy 15 (x86) and an HP rx6600 (ia64). It resolved the namespace failures on the Envy 15 and did not cause any regressions on the rx6600.

This does introduce a boot time namespace walk for all the CPUs in the system, looking for and evaluating _PDC. Hopefully that will not make life miserable for the giant SGI clusters. If worse comes to worse, maybe we can quirk them and avoid the namespace walk.

---

Alex Chiang (11):
ACPI: processor: call _PDC early
ACPI: processor: introduce arch_has_acpi_pdc
ACPI: processor: unify arch_acpi_processor_init_pdc
ACPI: processor: factor out common _PDC settings
ACPI: processor: finish unifying arch_acpi_processor_init_pdc()
ACPI: processor: unify arch_acpi_processor_cleanup_pdc
ACPI: processor: introduce acpi_processor_alloc_pdc()
ACPI: processor: change acpi_processor_eval_pdc interface
ACPI: processor: open code acpi_processor_cleanup_pdc
ACPI: processor: change acpi_processor_set_pdc() interface
ACPI: processor: remove _PDC object list from struct acpi_processor

 arch/ia64/include/asm/acpi.h      |    6 +
 arch/ia64/kernel/Makefile         |    4 -
 arch/ia64/kernel/acpi-processor.c |   85 -------------------
 arch/x86/include/asm/acpi.h       |   26 ++++++
 arch/x86/kernel/acpi/Makefile     |    2 
 arch/x86/kernel/acpi/processor.c  |  101 -----------------------
 drivers/acpi/Makefile             |    1 
 drivers/acpi/bus.c                |    2 
 drivers/acpi/internal.h           |    1 
 drivers/acpi/processor_core.c     |   71 ----------------
 drivers/acpi/processor_pdc.c      |  165 +++++++++++++++++++++++++++++++++++++
 include/acpi/processor.h          |    8 +-
 12 files changed, 206 insertions(+), 266 deletions(-)
 delete mode 100644 arch/ia64/kernel/acpi-processor.c
 delete mode 100644 arch/x86/kernel/acpi/processor.c
 create mode 100644 drivers/acpi/processor_pdc.c