Skip to content

IPv6 support for nfs-utils tcpwrapper shim (take 2)

Chuck Lever linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest6 patches 1 replyIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/6tcpwrappers: Use xlog() instead of perror(3) and syslog(2)support/misc/from_local.c+13 -120 replies
2/6tcp_wrappers: Use getifaddrs(3) if it is availableaclocal/ipv6.m4 configure.ac support/include/tcpwrapper.h +2 more+94 -120 replies
3/6tcp_wrapper: Clean up logit()support/include/tcpwrapper.= support/include/tcpwrapper.h support/misc/tcpwrapper.c +3 more+1 -20 replies
4/6tcpwrapper: Fix signage problems in the tcp_wrappers hash functionsupport/misc/tcpwrapper.c+0 -00 replies
5/6tcpwrapper: Eliminated shadowed declaration warningssupport/include/tcpwrapper.= support/include/tcpwrapper.h support/misc/tcpwrapper.c+0 -00 replies
6/6tcpwrapper: Add support for IPv6support/include/tcpwrapper.h support/misc/tcpwrapper.c utils/mountd/mount_dispatch.c +2 more+84 -480 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/6] IPv6 support for nfs-utils tcpwrapper shim (take 2)

These patches provide IPv6 support for the tcpwrapper shim inside nfs-utils.

We've confirmed that libwrap.a (at least the version included in Fedora 12) does support IPv6. Some of the man pages are missing some updates.

I've constructed some simple unit tests using an old program that can send bogus SM_NOTIFY requests. Switching hostnames and IPv6 addresses in and out of /etc/hosts.{allow,deny} shows this code with my patches to be operating as designed, for basic scenarios.

I also added more verbose logging in from_local() to confirm how the new getifaddrs(3) code is working. No unpleasant surprises there.

Testing resulted in no operational changes to the logic in any of these patches, but the extra logging seemed worth including, hence this redrive.

---

Chuck Lever (6):
tcpwrapper: Add support for IPv6
tcpwrapper: Eliminated shadowed declaration warnings
tcpwrapper: Fix signage problems in the tcp_wrappers hash function
tcp_wrapper: Clean up logit()
tcp_wrappers: Use getifaddrs(3) if it is available
tcpwrappers: Use xlog() instead of perror(3) and syslog(2)

 aclocal/ipv6.m4               |    4 -
 configure.ac                  |    2 
 support/include/tcpwrapper.h  |   12 +-
 support/misc/from_local.c     |  121 +++++++++++++++++++++---
 support/misc/tcpwrapper.c     |  203 ++++++++++++++++++++++++-----------------
 utils/mountd/mount_dispatch.c |    6 -
 utils/statd/statd.c           |    5 -
 utils/statd/statd.man         |    3 -
 8 files changed, 232 insertions(+), 124 deletions(-)
Signature · 1 line
chuck[dot]lever[at]oracle[dot]com