sysfs: fix s_active lockdep warning
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 36 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | sysfs: add support for lockdep subclasses to s_activefs/ include/ kernel/ | +27 | 0 replies | |
| 2/2 | sysfs: fix the incomplete part of subclass support for s_activefs/ fs/ fs/ | +5 | 0 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [Patch 0/2] sysfs: fix s_active lockdep warning
Recently we met a lockdep warning from sysfs during s2ram or cpu hotplug. As reported by several people, it is something like:
[ 6967.926563] ACPI: Preparing to enter system sleep state S3
[ 6967.956156] Disabling non-boot CPUs ...
[ 6967.970401]
[ 6967.970408] =============================================
[ 6967.970419] [ INFO: possible recursive locking detected ]
[ 6967.970431] 2.6.33-rc2-git6 #27
[ 6967.970439] ---------------------------------------------
[ 6967.970450] pm-suspend/22147 is trying to acquire lock:
[ 6967.970460] (s_active){++++.+}, at: [<c10d2941>]
sysfs_hash_and_remove+0x3d/0x4f
[ 6967.970493]
[ 6967.970497] but task is already holding lock:
[ 6967.970506] (s_active){++++.+}, at: [<c10d4110>]sysfs_get_active_two+0x16/0x36
[...]
Eric already provides a patch for this[1], but it still can't fix the problem. I add the missing part of Eric's patch and send these two patches together, hopefully we can fix the warning completely.
1. http://lkml.org/lkml/2010/1/10/282
Reported-by Benjamin Herrenschmidt <[email protected]>
Reported-by Larry Finger <[email protected]>
Reported-by Miles Lane <[email protected]>
Reported-by Heiko Carstens <[email protected]>
Signed-off-by WANG Cong <[email protected]>
Signed-off-by Eric W. Biederman <[email protected]>
Cc Tejun Heo <[email protected]>
Cc Greg Kroah-Hartman <[email protected]>