Skip to content

ide2libata

Bartlomiej Zolnierkiewicz linux-ide lkml 1 version In review

Get series with b4
b4 am 20100129160308.21495.14120.sendpatchset@localhost

Versions newest first

  1. v1 Latest68 patches 17 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/68piix: add new short cable IDsdrivers/ide/piix.c+3 -00 replies
2/68libata: CodingStyle fixes for ATA timings codedrivers/ata/libata-core.c+25 -140 replies
3/68libata: move ATA timings code to ata-timings.cdrivers/ata/Makefile drivers/ata/ata-timings.c drivers/ata/libata-core.c+180 -1740 replies
4/68ata: make ATA timings code independent of libatadrivers/ata/Kconfig drivers/ata/Makefile drivers/ata/ata-timings.c +16 more+115 -1170 replies
5/68ata: enable XFER_PIO_SLOW mode in ata_timing tabledrivers/ata/ata-timings.c+1 -10 replies
6/68ide: switch to generic ATA timings codedrivers/ide/Kconfig drivers/ide/Makefile drivers/ide/ali14xx.c +16 more+94 -3120 replies
7/68pata_pcmcia: move IDs table to pata_pcmcia.hdrivers/ata/pata_pcmcia.c drivers/ata/pata_pcmcia.h+67 -660 replies
8/68ide-cs: use pata_pcmcia.hdrivers/ide/ide-cs.c+2 -660 replies
9/68ata_piix: factor out short cable detection code to ich_short_ata40()drivers/ata/ata_piix.c+18 -100 replies
10/68ata_piix: move short cable handling to ata_piix.hdrivers/ata/ata_piix.c drivers/ata/ata_piix.h+46 -440 replies
11/68piix: use ata_piix.hdrivers/ide/piix.c+3 -380 replies
12/68pata_ali: move short cable handling to pata_ali.hdrivers/ata/pata_ali.c drivers/ata/pata_ali.h+41 -360 replies
13/68alim15x3: use pata_ali.hdrivers/ide/alim15x3.c+1 -410 replies
14/68pata_sis: move short cable handling to pata_sis.hdrivers/ata/pata_sis.c drivers/ata/pata_sis.h+31 -290 replies
15/68sis5513: use pata_sis.hdrivers/ide/sis5513.c+3 -220 replies
16/68pata_via: move short cable handling to pata_via.hdrivers/ata/pata_via.c drivers/ata/pata_via.h+30 -270 replies
17/68via82cxxx: use pata_via.hdrivers/ide/via82cxxx.c+1 -290 replies
18/68ide: split host->dev tabledrivers/ide/cy82c693.c drivers/ide/hpt366.c drivers/ide/ide-probe.c +4 more+12 -120 replies
19/68ide: add hwif->port_no fieldinclude/linux/ide.h+6 -10 replies
20/68ide: add hwif->udma_mask fieldinclude/linux/ide.h+4 -10 replies
21/68ide: add hwif->private_data fieldinclude/linux/ide.h+5 -10 replies
22/68ide: add drive->devno fielddrivers/ide/ide-probe.c include/linux/ide.h+2 -00 replies
23/68ide: add drive->class fieldinclude/linux/ide.h+7 -10 replies
24/68ide: change ->cable_detect method return type to 'int'drivers/ide/aec62xx.c drivers/ide/alim15x3.c drivers/ide/amd74xx.c +22 more+25 -250 replies
25/68it8213: always program control bitsdrivers/ide/it8213.c+2 -41 reply
26/68piix: always program control bitsdrivers/ide/piix.c+4 -80 replies
27/68slc90e66: always program control bitsdrivers/ide/slc90e66.c+4 -80 replies
28/68add ide2libata header fileinclude/linux/ide2libata.h+17 -00 replies
29/68ata_piix: move code to be re-used by ide2libata to ata_piix.hdrivers/ata/ata_piix.c drivers/ata/ata_piix.h+226 -2200 replies
30/68piix: convert to ide2libatadrivers/ata/ata_piix.h drivers/ide/piix.c+19 -1780 replies
31/68pata_ali: move code to be re-used by ide2libata to pata_ali.hdrivers/ata/pata_ali.c drivers/ata/pata_ali.h+241 -2400 replies
32/68alim15x3: convert to ide2libatadrivers/ata/pata_ali.h drivers/ide/alim15x3.c+61 -2540 replies
33/68pata_amd: move code to be re-used by ide2libata to pata_amd.hdrivers/ata/pata_amd.c drivers/ata/pata_amd.h+93 -860 replies
34/68amd74xx: convert to ide2libatadrivers/ata/pata_amd.h drivers/ide/amd74xx.c+25 -620 replies
35/68pata_artop: move code to be re-used by ide2libata to pata_artop.hdrivers/ata/pata_artop.c drivers/ata/pata_artop.h+231 -2310 replies
36/68aec62xx: convert to ide2libatadrivers/ata/pata_artop.h drivers/ide/aec62xx.c+90 -1790 replies
37/68pata_atiixp: move code to be re-used by ide2libata to pata_atiixp.hdrivers/ata/pata_atiixp.c drivers/ata/pata_atiixp.h+117 -1130 replies
38/68atiixp: convert to ide2libatadrivers/ide/atiixp.c+4 -1220 replies
39/68pata_cmd64x: documentation fixdrivers/ata/pata_cmd64x.c+1 -10 replies
40/68pata_cmd64x: move code to be re-used by ide2libata to pata_cmd64x.hdrivers/ata/pata_cmd64x.c drivers/ata/pata_cmd64x.h+216 -2140 replies
41/68pata_cmd64x: convert to ide2libatadrivers/ata/pata_cmd64x.h drivers/ide/cmd64x.c+41 -1890 replies
42/68pata_cs5520: move code to be re-used by ide2libata to pata_cs5520.hdrivers/ata/pata_cs5520.c drivers/ata/pata_cs5520.h+61 -590 replies
43/68cs5520: convert to ide2libatadrivers/ide/cs5520.c+4 -400 replies
44/68pata_cs5530: move code to be re-used by ide2libata to pata_cs5530.hdrivers/ata/pata_cs5530.c drivers/ata/pata_cs5530.h+184 -1770 replies
45/68cs5530: convert to ide2libatadrivers/ata/pata_cs5530.h drivers/ide/cs5530.c+25 -1400 replies
46/68pata_cs5535: move code to be re-used by ide2libata to pata_cs5535.hdrivers/ata/pata_cs5535.c drivers/ata/pata_cs5535.h+115 -1120 replies
47/68cs5535: convert to ide2libatadrivers/ide/cs5535.c+4 -1370 replies
48/68pata_cypress: move code to be re-used by ide2libata to pata_cypress.hdrivers/ata/pata_cypress.c drivers/ata/pata_cypress.h+89 -870 replies
49/68cy82c693: convert to ide2libatadrivers/ata/pata_cypress.h drivers/ide/cy82c693.c+29 -1310 replies
50/68pata_efar: move code to be re-used by ide2libata to pata_efar.hdrivers/ata/pata_efar.c drivers/ata/pata_efar.h+153 -1500 replies
51/68slc90e66: convert to ide2libatadrivers/ata/pata_efar.h drivers/ide/slc90e66.c+16 -1100 replies
52/68pata_it8213: move code to be re-used by ide2libata to pata_it8213.hdrivers/ata/pata_it8213.c drivers/ata/pata_it8213.h+151 -1490 replies
53/68it8213: convert to ide2libatadrivers/ata/pata_it8213.h drivers/ide/it8213.c+13 -1360 replies
54/68pata_it821x: move code to be re-used by ide2libata to pata_it821x.hdrivers/ata/pata_it821x.c drivers/ata/pata_it821x.h+319 -3180 replies
55/68it821x: convert to ide2libatadrivers/ata/pata_it821x.h drivers/ide/it821x.c+28 -3660 replies
56/68pata_pdc202xx_old: move code to be re-used by ide2libata to pata_pdc202xx_old.hdrivers/ata/pata_pdc202xx_old.c drivers/ata/pata_pdc202xx_old.h+110 -1080 replies
57/68pdc202xx_old: convert to ide2libatadrivers/ata/pata_pdc202xx_old.h drivers/ide/pdc202xx_old.c+18 -740 replies
58/68pata_sc1200: move code to be re-used by ide2libata to pata_sc1200.hdrivers/ata/pata_sc1200.c drivers/ata/pata_sc1200.h+113 -1070 replies
59/68sc1200: convert to ide2libatadrivers/ide/sc1200.c+4 -1090 replies
60/68pata_serverworks: move cable handling to pata_serverworks.hdrivers/ata/pata_serverworks.c drivers/ata/pata_serverworks.h+284 -2810 replies
61/68serverworks: convert to ide2libatadrivers/ata/pata_serverworks.h drivers/ide/serverworks.c+40 -2610 replies
62/68pata_sl82c105: move code to be re-used by ide2libata to pata_sl82c105.hdrivers/ata/pata_sl82c105.c drivers/ata/pata_sl82c105.h+107 -1050 replies
63/68sl82c105: convert to ide2libatadrivers/ata/pata_sl82c105.h drivers/ide/sl82c105.c+12 -950 replies
64/68pata_triflex: move code to be re-used by ide2libata to pata_triflex.hdrivers/ata/pata_triflex.c drivers/ata/pata_triflex.h+70 -710 replies
65/68triflex: convert to ide2libatadrivers/ide/triflex.c+6 -510 replies
66/68pata_via: factor out code for finding ISA bridgedrivers/ata/pata_via.c+23 -120 replies
67/68pata_via: move code to be re-used by ide2libata to pata_via.hdrivers/ata/pata_via.c drivers/ata/pata_via.h+242 -2370 replies
68/68via82cxxx: convert to ide2libatadrivers/ata/pata_via.h drivers/ide/via82cxxx.c+28 -2410 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 00/68] ide2libata

Hi,

Here is a patchset (on top of atang-v3.1 tree) applying "out-of-the-box" thinking to duplicated libata PATA and IDE subsystem host driver sets. Namely, it modifies IDE API slightly to match libata's one more, adds a tiny source-code level translation layer (ide2libata.h header file which consists of only 17 lines of code) and then converts host drivers to use shared source code for low-level operations (all drivers have been carefully audited during porting to minimize the probability of adding regressions accidentally). As an end result it is much easier to maintain both driver sets (differences between 'new'/'old' drivers are now apparent and there is no longer a need to manually back-port many classes of bugfixes) and over 2500 LOC are gone.

The following changes since commit 7a4716f9084b32e32511cdea64ba538ac11e2c90:
Bartlomiej Zolnierkiewicz (1):
ide: ide_timing_compute() fixup

are available in the git repository at:

git://git.kernel.org/pub/scm/linux/kernel/git/bart/misc.git atang-v4.0

Bartlomiej Zolnierkiewicz (68):
piix: add new short cable IDs
libata: CodingStyle fixes for ATA timings code
libata: move ATA timings code to ata-timings.c
ata: make ATA timings code independent of libata
ata: enable XFER_PIO_SLOW mode in ata_timing table
ide: switch to generic ATA timings code
pata_pcmcia: move IDs table to pata_pcmcia.h
ide-cs: use pata_pcmcia.h
ata_piix: factor out short cable detection code to ich_short_ata40()
ata_piix: move short cable handling to ata_piix.h
piix: use ata_piix.h
pata_ali: move short cable handling to pata_ali.h
alim15x3: use pata_ali.h
pata_sis: move short cable handling to pata_sis.h
sis5513: use pata_sis.h
pata_via: move short cable handling to pata_via.h
via82cxxx: use pata_via.h
ide: split host->dev table
ide: add hwif->port_no field
ide: add hwif->udma_mask field
ide: add hwif->private_data field
ide: add drive->devno field
ide: add drive->class field
ide: change ->cable_detect method return type to 'int'
it8213: always program control bits
piix: always program control bits
slc90e66: always program control bits
add ide2libata header file
ata_piix: move code to be re-used by ide2libata to ata_piix.h
piix: convert to ide2libata
pata_ali: move code to be re-used by ide2libata to pata_ali.h
alim15x3: convert to ide2libata
pata_amd: move code to be re-used by ide2libata to pata_amd.h
amd74xx: convert to ide2libata
pata_artop: move code to be re-used by ide2libata to pata_artop.h
aec62xx: convert to ide2libata
pata_atiixp: move code to be re-used by ide2libata to pata_atiixp.h
atiixp: convert to ide2libata
pata_cmd64x: documentation fix
pata_cmd64x: move code to be re-used by ide2libata to pata_cmd64x.h
pata_cmd64x: convert to ide2libata
pata_cs5520: move code to be re-used by ide2libata to pata_cs5520.h
cs5520: convert to ide2libata
pata_cs5530: move code to be re-used by ide2libata to pata_cs5530.h
cs5530: convert to ide2libata
pata_cs5535: move code to be re-used by ide2libata to pata_cs5535.h
cs5535: convert to ide2libata
pata_cypress: move code to be re-used by ide2libata to pata_cypress.h
cy82c693: convert to ide2libata
pata_efar: move code to be re-used by ide2libata to pata_efar.h
slc90e66: convert to ide2libata
pata_it8213: move code to be re-used by ide2libata to pata_it8213.h
it8213: convert to ide2libata
pata_it821x: move code to be re-used by ide2libata to pata_it821x.h
it821x: convert to ide2libata
pata_pdc202xx_old: move code to be re-used by ide2libata to pata_pdc202xx_old.h
pdc202xx_old: convert to ide2libata
pata_sc1200: move code to be re-used by ide2libata to pata_sc1200.h
sc1200: convert to ide2libata
pata_serverworks: move cable handling to pata_serverworks.h
serverworks: convert to ide2libata
pata_sl82c105: move code to be re-used by ide2libata to pata_sl82c105.h
sl82c105: convert to ide2libata
pata_triflex: move code to be re-used by ide2libata to pata_triflex.h
triflex: convert to ide2libata
pata_via: factor out code for finding ISA bridge
pata_via: move code to be re-used by ide2libata to pata_via.h
via82cxxx: convert to ide2libata

 drivers/ata/Kconfig             |    4 +
 drivers/ata/Makefile            |    2 +
 drivers/ata/ata-timings.c       |  178 ++++++++++++++++++
 drivers/ata/ata_piix.c          |  263 +---------------------------
 drivers/ata/ata_piix.h          |  278 +++++++++++++++++++++++++++++
 drivers/ata/libata-core.c       |  162 -----------------
 drivers/ata/pata_ali.c          |  270 +----------------------------
 drivers/ata/pata_ali.h          |  326 ++++++++++++++++++++++++++++++++++
 drivers/ata/pata_amd.c          |   89 +---------
 drivers/ata/pata_amd.h          |   94 ++++++++++
 drivers/ata/pata_artop.c        |  232 +------------------------
 drivers/ata/pata_artop.h        |  293 ++++++++++++++++++++++++++++++
 drivers/ata/pata_at32.c         |    8 +-
 drivers/ata/pata_at91.c         |   18 +--
 drivers/ata/pata_atiixp.c       |  114 +------------
 drivers/ata/pata_atiixp.h       |  116 ++++++++++++
 drivers/ata/pata_atp867x.c      |    5 +-
 drivers/ata/pata_cmd640.c       |    9 +-
 drivers/ata/pata_cmd64x.c       |  216 +----------------------
 drivers/ata/pata_cmd64x.h       |  246 +++++++++++++++++++++++++
 drivers/ata/pata_cs5520.c       |   60 +------
 drivers/ata/pata_cs5520.h       |   60 ++++++
 drivers/ata/pata_cs5530.c       |  178 +------------------
 drivers/ata/pata_cs5530.h       |  185 +++++++++++++++++++
 drivers/ata/pata_cs5535.c       |  113 +------------
 drivers/ata/pata_cs5535.h       |  114 ++++++++++++
 drivers/ata/pata_cypress.c      |   91 +----------
 drivers/ata/pata_cypress.h      |  108 +++++++++++
 drivers/ata/pata_efar.c         |  151 +----------------
 drivers/ata/pata_efar.h         |  161 +++++++++++++++++
 drivers/ata/pata_icside.c       |    4 +-
 drivers/ata/pata_it8213.c       |  150 +----------------
 drivers/ata/pata_it8213.h       |  157 ++++++++++++++++
 drivers/ata/pata_it821x.c       |  319 +---------------------------------
 drivers/ata/pata_it821x.h       |  337 +++++++++++++++++++++++++++++++++++
 drivers/ata/pata_legacy.c       |   32 ++--
 drivers/ata/pata_ns87410.c      |    7 +-
 drivers/ata/pata_ns87415.c      |    2 +-
 drivers/ata/pata_octeon_cf.c    |    4 +-
 drivers/ata/pata_pcmcia.c       |   67 +-------
 drivers/ata/pata_pcmcia.h       |   66 +++++++
 drivers/ata/pata_pdc202xx_old.c |  109 +-----------
 drivers/ata/pata_pdc202xx_old.h |  121 +++++++++++++
 drivers/ata/pata_sc1200.c       |  108 +-----------
 drivers/ata/pata_sc1200.h       |  112 ++++++++++++
 drivers/ata/pata_serverworks.c  |  282 +-----------------------------
 drivers/ata/pata_serverworks.h  |  303 +++++++++++++++++++++++++++++++
 drivers/ata/pata_sis.c          |   30 +---
 drivers/ata/pata_sis.h          |   30 +++
 drivers/ata/pata_sl82c105.c     |  106 +-----------
 drivers/ata/pata_sl82c105.h     |  110 ++++++++++++
 drivers/ata/pata_triflex.c      |   72 +--------
 drivers/ata/pata_triflex.h      |   69 +++++++
 drivers/ata/pata_via.c          |  255 +--------------------------
 drivers/ata/pata_via.h          |  269 ++++++++++++++++++++++++++++
 drivers/ide/Kconfig             |    1 +
 drivers/ide/Makefile            |    1 -
 drivers/ide/aec62xx.c           |  172 +-----------------
 drivers/ide/ali14xx.c           |    2 +-
 drivers/ide/alim15x3.c          |  295 ++-----------------------------
 drivers/ide/amd74xx.c           |   90 +++-------
 drivers/ide/at91_ide.c          |    9 +-
 drivers/ide/atiixp.c            |  126 +-------------
 drivers/ide/cmd640.c            |    4 +-
 drivers/ide/cmd64x.c            |  196 +-------------------
 drivers/ide/cs5520.c            |   44 +----
 drivers/ide/cs5530.c            |  149 ++--------------
 drivers/ide/cs5535.c            |  141 +--------------
 drivers/ide/cs5536.c            |    2 +-
 drivers/ide/cy82c693.c          |  132 +-------------
 drivers/ide/hpt366.c            |    8 +-
 drivers/ide/ht6560b.c           |    3 +-
 drivers/ide/ide-cs.c            |   68 +-------
 drivers/ide/ide-probe.c         |    3 +-
 drivers/ide/ide-timings.c       |  217 ----------------------
 drivers/ide/ide-xfer-mode.c     |   25 +++
 drivers/ide/ide.c               |    4 +-
 drivers/ide/it8213.c            |  140 +--------------
 drivers/ide/it821x.c            |  375 +--------------------------------------
 drivers/ide/jmicron.c           |    2 +-
 drivers/ide/palm_bk3710.c       |    9 +-
 drivers/ide/pdc202xx_new.c      |    4 +-
 drivers/ide/pdc202xx_old.c      |   80 +--------
 drivers/ide/piix.c              |  226 ++----------------------
 drivers/ide/pmac.c              |    8 +-
 drivers/ide/qd65xx.c            |    2 +-
 drivers/ide/sc1200.c            |  113 +-----------
 drivers/ide/scc_pata.c          |    2 +-
 drivers/ide/serverworks.c       |  281 ++---------------------------
 drivers/ide/setup-pci.c         |    6 +-
 drivers/ide/siimage.c           |    2 +-
 drivers/ide/sis5513.c           |   27 +---
 drivers/ide/sl82c105.c          |  105 +----------
 drivers/ide/slc90e66.c          |  117 +------------
 drivers/ide/tc86c001.c          |    2 +-
 drivers/ide/triflex.c           |   57 +------
 drivers/ide/tx4938ide.c         |    2 +-
 drivers/ide/tx4939ide.c         |    2 +-
 drivers/ide/via82cxxx.c         |  290 +++---------------------------
 include/linux/ata.h             |   43 +++++
 include/linux/ide.h             |   66 +++----
 include/linux/ide2libata.h      |   17 ++
 include/linux/libata.h          |   37 ----
 103 files changed, 4147 insertions(+), 6825 deletions(-)
 create mode 100644 drivers/ata/ata-timings.c
 create mode 100644 drivers/ata/ata_piix.h
 create mode 100644 drivers/ata/pata_ali.h
 create mode 100644 drivers/ata/pata_amd.h
 create mode 100644 drivers/ata/pata_artop.h
 create mode 100644 drivers/ata/pata_atiixp.h
 create mode 100644 drivers/ata/pata_cmd64x.h
 create mode 100644 drivers/ata/pata_cs5520.h
 create mode 100644 drivers/ata/pata_cs5530.h
 create mode 100644 drivers/ata/pata_cs5535.h
 create mode 100644 drivers/ata/pata_cypress.h
 create mode 100644 drivers/ata/pata_efar.h
 create mode 100644 drivers/ata/pata_it8213.h
 create mode 100644 drivers/ata/pata_it821x.h
 create mode 100644 drivers/ata/pata_pcmcia.h
 create mode 100644 drivers/ata/pata_pdc202xx_old.h
 create mode 100644 drivers/ata/pata_sc1200.h
 create mode 100644 drivers/ata/pata_serverworks.h
 create mode 100644 drivers/ata/pata_sis.h
 create mode 100644 drivers/ata/pata_sl82c105.h
 create mode 100644 drivers/ata/pata_triflex.h
 create mode 100644 drivers/ata/pata_via.h
 delete mode 100644 drivers/ide/ide-timings.c
 create mode 100644 include/linux/ide2libata.h