Skip to content

Initial multi-omap support for omap4

Tony Lindgren linux-arm-kernel linux-omap 1 version New

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest0 of 9 patches 0 repliesNew

Patches in v1 No applies recorded yet

None of the 9 patches the cover letter announces are in this archive.

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/9] Initial multi-omap support for omap4
Quoted 40 lines · Shilimkar, Santosh
Quoted 40 lines

-----Original Message-----
From: Tony Lindgren [mailto:[email protected]]
Sent: Saturday, January 30, 2010 9:55 PM
To: Shilimkar, Santosh
Cc: [email protected]; [email protected]
Subject: Re: [PATCH 0/9] Initial multi-omap support for omap4

Quoted 32 lines · Shilimkar, Santosh
Quoted 6 lines
Quoted 6 lines

Hi all,

These patches allow compiling in also omap4 into the multi-omap configuration. As I don't yet have omap4, I've only boot tested these on omap2 and omap3.

Quoted 8 lines
Quoted 3 lines

Somebody with an omap4 board please boot test these with the omap3_defconfig and see what happens.. You might want to enable DEBUG_LL and EARLY_PRINTK with earlyprintk on the cmdline too.

Looks like this series have some dependent series because it doesn't apply on mainline.

So I tested this directly on linux-omap "multi-omap4" branch. It boots sufficiently but doesn't proceed after "brd_init". Didn't get much time to debug so attached log

Stand alone omap_4430sdp_defconfig also didn't fully boot on the linux-omap "multi-omap4". The log below shows that the serial platform data isn't configured correctly.

<6>io scheduler deadline registered
<6>io scheduler cfq registered (default)
<6>Serial: 8250/16550 driver, 4 ports, IRQ sharing enabled <6>serial8250.0: ttyS0 at MMIO 0x4806a000 (irq = 104) is a ST16654 <6>serial8250.1: ttyS0 at MMIO 0x4806a000 (irq = 105) is a ST16654

Below patch to fix the boot for omap_4430sdp_defconfig. Small typo really.

arch/arm/plat-omap/include/plat/serial.h +0 -0
index 67ffa08..83dce4c 100644
@@ -33,7 +33,7 @@
 
Quoted 6 lines
Quoted 6 lines

arch/arm/plat-omap/include/plat/serial.h line 38

Quoted 6 lines
arch/arm/plat-omap/include/plat/serial.h +1 -1
 /* OMAP4 serial ports */
 #define OMAP4_UART1_BASE       OMAP2_UART1_BASE
-#define OMAP4_UART2_BASE       OMAP2_UART1_BASE
+#define OMAP4_UART2_BASE       OMAP2_UART2_BASE
 #define OMAP4_UART3_BASE       0x48020000
 #define OMAP4_UART4_BASE       0x4806e000

I've refreshed the second patch in the earlier multi-omap series with your fix above.

Quoted 5 lines
Quoted 4 lines

Heh OK :) Sounds like at this point it makes sense to merge that into the original patch redo omap-for-linus partially.

Can I also add your Acked-by for these patches then?

Yes please.

OK, added your Acked-by to all the omap4 patches. Also fixed three checkpatch.pl warnings about long lines for the gpio patch.

Quoted 8 lines
Quoted 8 lines
Quoted 2 lines

For multi-omap build, for now I need to disable
[*] Reset unused clocks during boot

Sounds like omap4 has some clocks left on from the bootloader that it should clk_get and clk_enable during init. That should be easy to track if you boot with "debug" in your cmdline and take a look at the list of unused clocks that are shut down with late_initcall.

Quoted 6 lines

I know it hangs when it tries to cut down UART3 ( console) clock. The clock support got just recently merged and drivers are not yet migrated so, need to still depend on bootloader. The work is ongoing and soon the patches will be pushed. Few drivers are planned to be handled in hwmod way so we were holding these patches.

OK

Tony