Skip to content

per-bdi flushing model improvements. reiser4

Edward Shishkin linux-fsdevel linux-xfs lkml reiserfs-devel 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest7 patches 10 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/7roll back reiser4-fixed-null-pointer-dereference.patchfs/reiser4/super_ops.c+1 -10 replies
2/7roll back reiser4-generic_sync_sb_inodes-doesnt-exist-anymore.patchfs/reiser4/context.h fs/reiser4/entd.c fs/reiser4/super_ops.c+4 -80 replies
3/7roll back vfs-add-super_operationssync_inodes-2.patchfs/fs-writeback.c include/linux/fs.h+1 -60 replies
4/7VFS: improve writeback_inodes_wbfs/fs-writeback.c include/linux/writeback.h+76 -600 replies
5/7VFS: add super operation writeback_inodesfs/fs-writeback.c include/linux/fs.h include/linux/writeback.h+59 -40 replies
6/7reiser4: writeback_inodes implementationfs/reiser4/context.c fs/reiser4/context.h fs/reiser4/entd.c +3 more+45 -301 reply
7/7reiser4: fixup checkin-checkout jnodes for entdfs/reiser4/plugin/file/file.c fs/reiser4/vfs_ops.c+7 -30 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [patch 0/7] per-bdi flushing model improvements. reiser4

Hello.

Quoted 6 lines · Andrew Morton

reiser4 is currently disabled in -mm (via reiser4-disable.patch) because recent changes to fs/fs/writeback.c wrecked the build. I fixed it about ten times as the underlying code was churning, then gave up. It would be nice if you take a look at that sometime please.

I have taken a look at fs/fs-writeback.c and found that per-superblock flushing interface is eliminated. However migrating to per-bdi flushing model doesn't necessarily means that such interface doesn't exist or is not needed anymore. Flushing in accordance with the scheme "data-inode- data-inode-..." would be very suboptimal for reiser4. Also xfs people were unhappy with such flushing model:
http://article.gmane.org/gmane.linux.file-systems/30153

Moreover, current stuff doesn't look fine. Why do we pin/unpin superblock for every inode? It would be more reasonable to pin it for the whole group of inodes and call a flushing handler for them. The patch 4 introduces such handler writeback_sb_inodes (which resembles dropped sync_sb_inodes, the difference is that the newer version doesn't flush necessarily all inodes of the superblock). Please, consider pushing this patch to mainline.

The patch 5 adds a super operation .writeback_inodes (former .sync_inodes) which allows a file system to make optimizations. It can happen that reiser4 will flush a bit more inodes then generic implementation suggests. "a bit more" doesn't mean "all dirty inodes of the superblock" (see a comment about atoms in the header of patch 6).

Finally, some file systems have its own means for periodical writeout of dirty data. Since b_io contains inodes of many superblocks we need to evict our inodes back to dirty list when flushing is going on with for_kupdate flag installed. The new library function writeback_skip_sb_inodes() provides such possibility.

Please, apply.

Thanks,
Edward.