Skip to content

RFC wsync export option

Ben Myers linux-nfs linux-xfs 1 version In review

Get series with b4
b4 am 20100203233755.17677.96582.stgit@case

Versions newest first

  1. v1 RFC Latest4 patches 12 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/4Add 'wsync' export option.fs/nfsd/export.c include/linux/nfsd/export.h+4 -10 replies
2/4Add datasync argument to nfsd_sync_dir().fs/nfsd/nfs4recover.c fs/nfsd/vfs.c fs/nfsd/vfs.h+11 -110 replies
3/4If 'wsync' call vfs_fsync() instead of write_inode_now().fs/nfsd/vfs.c+20 -50 replies
4/4If 'wsync' pass datasync=1 to vfs_fsync().fs/nfsd/vfs.c+25 -146 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [RFC PATCH 0/4] wsync export option

In April I did some research on why synchronous NFSv3 performance on XFS is so rotten when compared to local filesystem performance. The workload I chose to work with is tar.

After taking some measurements I came to the conclusion that one of the big problems is that we're not treating the log as stable storage. By calling write_inode_now() we've written the changes to the log first and then gone and also written them out to the inode on disk.

In a short discussion of this issue on the xfs-oss list it was suggested that I post the patches here for discussion.

The following series is adds a 'wsync' export option to nfsd. It is intended to be used on XFS with the wsync mount option. When you already have a synchronous log there is no need to sync metadata separately.

This is barely tested, YMMV, I could have this all wrong, etc, etc. Here are some very unscientific measurements taken over gigabit ethernet.

# time tar -xvf /mnt2/quilt-0.47.tar > /dev/null

No XFS wsync, no NFS wsync:
0m13.177s 0m13.301s 0m13.528s

XFS wsync set, no NFS wsync:
0m13.019s 0m13.232s 0m13.094s

XFS wsync set, NFS wsync set:
0m8.361s 0m8.400s 0m8.301s

Curious to hear if this is a reasonable thing to do. Suggestions welcome.

Thanks!
Ben

---

Ben Myers (4):
Add 'wsync' export option.
Add datasync argument to nfsd_sync_dir().
If 'wsync' call vfs_fsync() instead of write_inode_now(). If 'wsync' pass datasync=1 to vfs_fsync().

 fs/nfsd/export.c            |    1 +
 fs/nfsd/nfs4recover.c       |    2 +
 fs/nfsd/vfs.c               |   62 +++++++++++++++++++++++++++++++------------
 fs/nfsd/vfs.h               |    2 +
 include/linux/nfsd/export.h |    4 ++-
 5 files changed, 50 insertions(+), 21 deletions(-)