Fixes for edb9315
Get series with b4
b4 am 20100206221527.GA25569@darwinVersions newest first
- v1 Latest3 patches 0 repliesNew
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | EP93xx: fix syscon_regs definition | +0 | 0 replies | |
| 2/3 | edb93xx: change calculation un early_udelay.h | +0 | 0 replies | |
| 3/3 | edb93xx: enable the uart in devicecfg register | +0 | 1 reply |
Reviews trailers per patch
All 3 patches have a Reviewed-by or Acked-by.
| Patch | Matthias Kaehlcke |
|---|---|
| 1/3 | A-b |
| 2/3 | A-b |
| 3/3 | A-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [U-Boot] [PATCH 0/3] Fixes for edb9315
Hi Alessandro,
El Sat, Feb 06, 2010 at 08:53:30PM +0100 Alessandro Rubini ha dit:
Quoted 9 lines
I'm porting current u-boot to a board similar to EP9315A, so I'm using arm/master as a basis, as it includes the patches by Matthias Kaehlcke. I'm currently running from RAM (
SKIP_LOWLEVEL_INIT), after setting up sdram and pll elsewhere (older vendor u-boot code, still to be ported)."fix
syscon_regsdefinition" is needed to access any software-locked syscon register from C code (e.g., inreset_cpu()and devicecfg used by me in patch 3).
you are right, i missed the gap between ChipID and SysCfg
Quoted 4 lines
"change calculation un
early_udelay.h" is needed at least for eldk-4.2 (gcc-4.2.2), as without this patch it will use the stack before setting SP. Actually, we could use the ether buffer as a stack, if needed, but it's not really needed here.
i feared this could happen with different compiler versions, your fix certainly reduces the risk
Quoted 3 lines
"enable the uart in devicecfg register" prevents u-boot from freezing at least with
SKIP_LOWLEVEL_INITset, but I'm pretty surelowlevel_setupassembly code doesn't enable the uart, either.
my ep9301 and ep9307 based boards for some reason boot with the uart enabled, though according to the datasheet it is disabled until enabled explicitly. therefore your fix is necessary for all cpus behaving as expected.
thanks a lot for your patches!
Signature · 10 lines
Matthias Kaehlcke
Embedded Linux Developer
Barcelona
The assumption that what currently exists must necessarily
exist is the acid that corrodes all visionary thinking
.''`.
using free software / Debian GNU/Linux | http://debian.org : :' :
`. `'`
gpg --keyserver pgp.mit.edu --recv-keys 47D8E5D4 `-