Skip to content

Reduce GETATTRs during direct I/O

Chuck Lever linux-nfs 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest2 patches 6 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/2NFS: Too many GETATTR and ACCESS calls after direct I/Ofs/nfs/direct.c+3 -00 replies
2/2NFS: Don't generate a GETATTR when opening an O_DIRECT filefs/nfs/dir.c+16 -46 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/2] Reduce GETATTRs during direct I/O

Hi Trond-

I mentioned this one to you last week. I found that the NFS direct I/O engine appears to be missing calls to nfs_fattr_init(). Please take a look at these two patches and let me know if they look reasonable for 2.6.34.

The problem also appears in the enterprise linux kernels. We're still testing this on EL4 and EL5 in specific. We haven't found evidence so far of incorrect behavior after applying the direct.c fix. A bugzilla report is forthcoming.

I haven't convinced myself that the extra GETATTR when opening an O_DIRECT file is ever necessary. But, I coded up a patch to your specifications that changes O_DIRECT opens to avoid a GETATTR when possible.

---

Chuck Lever (2):
NFS: Don't generate a GETATTR when opening an O_DIRECT file
NFS: Too many GETATTR and ACCESS calls after direct I/O

 fs/nfs/dir.c    |   20 ++++++++++++++++----
 fs/nfs/direct.c |    3 +++
 2 files changed, 19 insertions(+), 4 deletions(-)
Signature · 1 line
Chuck Lever