Skip to content

Was: x86: get rid of the insane TIF_ABI_PENDING bit

Oleg Nesterov lkml 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest3 patches 9 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3x86: set_personality_ia32() misses force_personality32arch/x86/kernel/process_64.c+1 -01 reply
2/3x86: set_personality_ia32() abuses TS_COMPATarch/x86/kernel/process_64.c+0 -37 replies
3/3x86: ELF_PLAT_INIT() shouldn't worry about TIF_IA32arch/x86/include/asm/elf.h+1 -41 reply

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.

Read the v1 thread

Cover letter [PATCH 0/3] Was: x86: get rid of the insane TIF_ABI_PENDING bit
Quoted 10 lines · Andi Kleen
Quoted 4 lines · Oleg Nesterov

Agreed, but otoh it is always good to understand the code. If we really have a reason for TS_COMPAT, a small comment can help other readers.

My memory is somewhat fuzzy on this one, but I think it was related to VMA placement (probably for stack randomization or something like that) This happens before the first call. I might be wrong on that.

Afaics we never check TS_COMPAT/is_compat_task for this...

Quoted 2 lines

There might also have been other is_compat_task checks in the exec init path, so partly it was defensive programming.

Understand, but it looks so confusing...

OK. Please feel free to ignore, but I am sending the trivial, but only compile-tested patches. My main motivation is to simplify the reading and understanding of this code.

The first patch looks like an "obvious" bugfix for 2.6.33 though, but still untested.

Oleg.