Was: x86: get rid of the insane TIF_ABI_PENDING bit
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest3 patches 9 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/3 | x86: set_personality_ia32() misses force_personality32arch/ | +1 | 1 reply | |
| 2/3 | x86: set_personality_ia32() abuses TS_COMPATarch/ | +0 | 7 replies | |
| 3/3 | x86: ELF_PLAT_INIT() shouldn't worry about TIF_IA32arch/ | +1 | 1 reply |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/3] Was: x86: get rid of the insane TIF_ABI_PENDING bit
Quoted 10 lines · Andi Kleen
Quoted 4 lines · Oleg Nesterov
Agreed, but otoh it is always good to understand the code. If we really have a reason for
TS_COMPAT, a small comment can help other readers.My memory is somewhat fuzzy on this one, but I think it was related to VMA placement (probably for stack randomization or something like that) This happens before the first call. I might be wrong on that.
Afaics we never check TS_COMPAT/is_compat_task for this...
Quoted 2 lines
There might also have been other
is_compat_taskchecks in the exec init path, so partly it was defensive programming.
Understand, but it looks so confusing...
OK. Please feel free to ignore, but I am sending the trivial, but only compile-tested patches. My main motivation is to simplify the reading and understanding of this code.
The first patch looks like an "obvious" bugfix for 2.6.33 though, but still untested.
Oleg.