sunrpc: use monotonic time for expiry times
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest2 patches 2 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/2 | sunrpc: extract some common sunrpc_cache code from nfsdfs/ include/ | +9 | 0 replies | |
| 2/2 | sunrpc: use monotonic time in expiry cachefs/ fs/ include/ +1 more | +40 | 2 replies |
Reviews trailers per patch
No Reviewed-by, Acked-by or Tested-by trailers for v1 yet.
Cover letter [PATCH 0/2] sunrpc: use monotonic time for expiry times
I've always known I would pay for this some day ....
The authentication cache uses wall-clock time for expiry times and related time stamps.
This can cause problems if the wall-clock time changes suddenly. e.g. if you set the time forward one hour, the export cache is immediately flushed. This isn't an enormous problem, but it should be fixed.
Currently, it can cause clients to have to resend requests which can cause a delay of several timeouts. Once we get the improvements in which allow a thread to wait for a while rather than dropping a request, this will be less of an issue. But I think it is worth fixing anyway.
So: two patches. One moves come common code to an inline, the other makes the change.
comments?
Thanks,
NeilBrown
---
NeilBrown (2):
sunrpc: extract some common sunrpc_cache code from nfsd
sunrpc: use monotonic time in expiry cache
fs/nfs/dns_resolve.c | 6 +++--- fs/nfsd/export.c | 9 +++------ fs/nfsd/nfs4idmap.c | 2 +- include/linux/sunrpc/cache.h | 23 ++++++++++++++++++++++- net/sunrpc/cache.c | 33 ++++++++++++++++++--------------- 5 files changed, 47 insertions(+), 26 deletions(-)