Skip to content

sdhci-pltfm: Few additions and enhancements

Anton Vorontsov linux-mmc lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v1 Latest posting 2/23 patches 5 repliesIn review
  2. v1 posting 1/23 patches 2 repliesSuperseded

Patches in v1 posting 2/2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/3sdhci: Implement CAP_CLOCK_BASE_BROKEN quirkdrivers/mmc/host/sdhci.c drivers/mmc/host/sdhci.h+4 -10 replies
2/3sdhci-pltfm: Implement platform data passingdrivers/mmc/host/sdhci-pltfm.c include/linux/sdhci-pltfm.h+47 -42 replies
3/3sdhci-pltfm: Do not print errors in case of an extended iomem sizedrivers/mmc/host/sdhci-pltfm.c+1 -14 replies

Reviews trailers per patch

1 of 3 patches has a Reviewed-by or Acked-by.

PatchRichard Röjfors
1/3
2/3
3/3A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH resend 0/3] sdhci-pltfm: Few additions and enhancements
Quoted 9 lines · Anton Vorontsov
Quoted 7 lines · David Vrabel
Quoted 3 lines · Anton Vorontsov

Some hosts (e.g. as found in CNS3xxx SOCs) report wrong value in CLOCK_BASE capability field, and currently there is no way to force the SDHCI core to use the platform-provided base clock value.

I don't think this needs a new quirk. Change the sdhci driver to check if the platform provides a value before reading the standard register.

Quoted 8 lines

Well, Pierre once said that by default we should conform to the SDHCI spec, and any diviations from the spec should be handled by the quirks:

http://linux.derkeiler.com/Mailing-Lists/Kernel/2009-02/msg03385.html

Spec clearly states that base clock == 0 is the case when we should fall back to the platform-provided clocks.

No further comments, resending the patches...

Thanks,

Signature · 3 lines
Anton Vorontsov
email: [email protected]
irc://irc.freenode.net/bd2