v6 add lockdep-based diagnostics to rcu_dereference()
Status from this message: I've applied them to tip:core/rcu, Thanks Paul!
Get series with b4
b4 am [email protected]Versions newest first
Patches in v1 Applied
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/21 | rcu: introduce lockdep-based checking to RCU read-side primitivesinclude/ include/ kernel/ +4 more | +267 | 1 reply | |
| 2/21 | rcu: add lockdep-enabled variants of rcu_dereference()include/ include/ | +42 | 1 reply | |
| 3/21 | rcu: integrate rcu_dereference_check() message into lockdepinclude/ include/ kernel/ | +24 | 1 reply | |
| 4/21 | rcu: disable lockdep checking in RCU list-traversal primitivesinclude/ include/ | +9 | 1 reply | |
| 5/21 | net: add checking to rcu_dereference() primitivesinclude/ include/ net/ +6 more | +35 | 1 reply | |
| 6/21 | sched: use lockdep-based checking on rcu_dereference()include/ include/ init/ +6 more | +43 | 2 replies | |
| 7/21 | sched: better name for for_each_domain_rdkernel/ | +2 | 1 reply | |
| 8/21 | vfs: apply lockdep-based checking to rcu_dereference() usesfs/ fs/ fs/ +1 more | +14 | 1 reply | |
| 9/21 | vfs: abstract rcu_dereference_check for files-fdtable useinclude/ | +7 | 1 reply | |
| 10/21 | radix-tree: disable RCU lockdep checking in radix treelib/ | +12 | 1 reply | |
| 11/21 | idr: apply lockdep-based diagnostics to rcu_dereference() useslib/ | +4 | 1 reply | |
| 12/21 | security: apply lockdep-based checking to rcu_dereference() usessecurity/ security/ | +5 | 1 reply | |
| 13/21 | rcu: documentation update for CONFIG_PROVE_RCUDocumentation/ Documentation/ Documentation/ +1 more | +97 | 1 reply | |
| 14/21 | rcu: fix citation of Mathieu's dissertationDocumentation/ | +4 | 1 reply | |
| 15/21 | rcu: accelerate grace period if last non-dynticked CPUinclude/ init/ kernel/ +1 more | +101 | 1 reply | |
| 16/21 | rcu: use canonical URL for Mathieu's dissertationDocumentation/ | +1 | 1 reply | |
| 17/21 | rcu: stop overflowing signed integerskernel/ kernel/ kernel/ | +30 | 1 reply | |
| 18/21 | rcu: Convert to raw_spinlockskernel/ kernel/ kernel/ | +92 | 1 reply | |
| 19/21 | rcu: fix deadlock in TREE_PREEMPT_RCU CPU stall detectionkernel/ kernel/ | +2 | 1 reply | |
| 20/21 | rcu: fix rcutorture mod_timer argument to delay one jiffykernel/ | +1 | 1 reply | |
| 21/21 | rcu: add RCU_CPU_STALL_VERBOSE to dump detailed per-task informationkernel/ kernel/ kernel/ +1 more | +69 | 1 reply |
Reviews trailers per patch
3 of 21 patches have a Reviewed-by or Acked-by.
| Patch | Eric Dumazet | Mathieu Desnoyers | John Kacur | Thomas Gleixner | David S. Miller |
|---|---|---|---|---|---|
| 1/21 | |||||
| 2/21 | A-b A-b | ||||
| 3/21 | |||||
| 4/21 | |||||
| 5/21 | A-b A-b | A-b A-b | |||
| 6/21 | |||||
| 7/21 | |||||
| 8/21 | |||||
| 9/21 | |||||
| 10/21 | |||||
| 11/21 | |||||
| 12/21 | |||||
| 13/21 | |||||
| 14/21 | |||||
| 15/21 | |||||
| 16/21 | |||||
| 17/21 | A-b A-b | ||||
| 18/21 | |||||
| 19/21 | T-b T-b | T-b Located-by T-b Located-by | |||
| 20/21 | |||||
| 21/21 |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.
Cover letter [PATCH tip/core/rcu 0/21] v6 add lockdep-based diagnostics to rcu_dereference()
Hello!
This patch series adds lockdep-based checking to the rcu_dereference() primitive in order to flag misuses of RCU. The first four patches put the RCU infrastructure in place, the next eight use this infrastructure in the net, sched, vfs, radix-tree, idr, and security subsystems, and patch 13 documents how to use the new lockdep-checked rcu_dereference() primitives. The remaining eight patches are other changes that also need to be applied, including some relatively urgent RCU_STALL patches.
The new (and default-disabled) CONFIG_PROVE_RCU makes this safe to include in tip/core/rcu -- unlike v2 and earlier, your system won't complain about RCU misuse unless you ask it to. There are still several situations that trigger on systems I have access to (and I have email out on a couple of them), some of the remaining will be triggered only by hardware I don't have access to and kernel features I am unfamiliar with. So this is ready for much wider testing.
Changes since v5 (http://lkml.org/lkml/2010/2/17/271)
o Fix a deadlock located by Thomas Gleixner that affects
TREE_PREEMPT_RCU in some CPU-stall detection scenarios.
o Add Dan Carpenter's cleanup to a mod_timer() in rcutorture.
o Add a RCU_CPU_STALL_VERBOSE to enable dumping more information
on tasks stalling the current RCU grace period.
o Applied Acked-by lines that people have sent (thank you all!).
Changes since v4 (http://lkml.org/lkml/2010/2/11/356)
o Apply review comments from Peter Ziljstra.
o Another documentation update.
o Fixes that avoid overflowing signed integers.
o Rebased Thomas Gleixner's raw-spinlock patch on this series.
(Thomas's original at http://lkml.org/lkml/2010/2/17/182.)
Changes since v3 (http://lkml.org/lkml/2010/1/14/505)
o Fix a few more issues identified by the checking.
o Add a documentation update.
o Accelerate RCU grace periods when the current CPU is the last
non-dyntick-idle CPU in the system, which is important for some multi-core battery-powered devices.
Changes since v2 (http://lkml.org/lkml/2010/1/4/496):
o Removed references to the check condition for the non-lockdep
version of rcu_dereference_check(), thus preventing numerous build errors.
o Create a CONFIG_PROVE_RCU (default disabled) so that developers
who want to use lockdep only to debug locks aren't bothered by RCU-specific lockdep complaints that will no doubt persist for a little bit while some of the more obscure uses of RCU are reverse-engineered.
o Fix a few more issues identified by the checking.
o Add documentation in Documentation/RCU/lockdep.txt.
Changes since v1 (http://lkml.org/lkml/2009/12/15/553):
o Made SRCU have per-srcu_struct lockdep maps to prevent lockdep
from conflating independent uses of SRCU, and updated the rcu_dereference() checking in rcutorture to match.
o Fix a few issues identified by the checking.
o Disable checking within RCU list macros, RCU radix trees, and
IDR.