Skip to content

: Cleanups checkpoint.c, restart.c

Sukadev Bhattiprolu containers 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 of 13 patches 3 repliesIn review

12 of 13 patches are in this archive. The cover letter announces 13.

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
2/13: restart: Rename args->logfdrestart.c+13 -130 replies
3/13: restart: Remove args->logfilerestart.c+16 -130 replies
4/13: restart: Use ckpt_msg() to logrestart.c+63 -270 replies
5/13: restart: Use ckpt_perror()restart.c+49 -430 replies
6/13: restart: Remove args->inputrestart.c+13 -120 replies
7/13: Define app_restart()restart.c+32 -260 replies
8/13: restart: Rename struct args.restart.c+5 -50 replies
9/13: checkpoint: Remove args->outputcheckpoint.c+15 -140 replies
10/13: checkpoint: Remove ->logfilecheckpoint.c+14 -140 replies
11/13: checkpoint: Rename struct argscheckpoint.c+3 -30 replies
12/13: Define app_checkpoint()checkpoint.c+29 -210 replies
13/13: checkpoint: Use ckpt_perror()checkpoint.c+49 -110 replies

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSerge Hallyn
SeriesA-b
2/13
3/13
4/13
5/13
6/13
7/13
8/13
9/13
10/13
11/13
12/13
13/13

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 00/13][user-cr]: Cleanups checkpoint.c, restart.c

[PATCH 00/13][user-cr]: Cleanups checkpoint.c, restart.c

These patches perform some cleanups/reorg of the code in checkpoint.c and restart.c files. These changes remove redundant fields in data structures, rename some fields/functions and avoid directly using stdout/stderr.

The changes will help us later export app_checkpoint() and app_restart() to larger container implementations such as LXC.

	[PATCH 01/13][user-cr]: restart: Remove args->no_pidns.
	[PATCH 02/13][user-cr]: restart: Rename args->logfd
	[PATCH 03/13][user-cr]: restart: Remove args->logfile 
	[PATCH 04/13][user-cr]: restart: Use ckpt_msg() to log
	[PATCH 05/13][user-cr]: restart: Use ckpt_perror()
	[PATCH 06/13][user-cr]: restart: Remove args->input
	[PATCH 07/13][user-cr]: Define app_restart()
	[PATCH 08/13][user-cr]: restart: Rename struct args.
	[PATCH 09/13][user-cr]: checkpoint: Remove args->output
	[PATCH 10/13][user-cr]: checkpoint: Remove ->logfile
	[PATCH 11/13][user-cr]: checkpoint: Rename struct args
	[PATCH 12/13][user-cr]: Define app_checkpoint()
	[PATCH 13/13] checkpoint: Use ckpt_perror()