Skip to content

: Second set of cleanups

Sukadev Bhattiprolu containers 1 version NAK

Status from this message: Nack - the library should not handle signals for callers.

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest12 patches 6 repliesNAK

Patches in v1

#Subject and filesSizeRepliesApplied
1/12restart: Mark globals as staticrestart.c+9 -90 replies
2/12restart: Add args->send_sigintrestart.c+5 -11 reply
3/12Add app_restart_args->debugrestart.c+3 -12 replies
4/12Add app_restart_args->verboserestart.c+3 -10 replies
5/12Add app_restart_args->ulogfdrestart.c+3 -00 replies
6/12Add app_restart_args->uerrfdrestart.c+3 -00 replies
7/12Define INIT_SIGNAL_ARRAYrestart.c+40 -360 replies
8/12Create common.hMakefile checkpoint.c common.h +1 more+119 -1382 replies
9/12Create app-checkpoint.hMakefile app-checkpoint.h checkpoint.c +1 more+40 -330 replies
10/12restart: Move main() to restart-main.cMakefile restart-main.c restart.c+354 -3330 replies
11/12checkpoint: Move main() to checkpoint-main.cMakefile checkpoint-main.c checkpoint.c+174 -1580 replies
12/12Have app_restart() return pidrestart-main.c restart.c+12 -10 replies

Reviews trailers per patch

None of the 12 patches has a Reviewed-by or Acked-by of their own; the series has one for all of them.

PatchSerge Hallyn
SeriesA-b
1/12
2/12
3/12
4/12
5/12
6/12
7/12
8/12
9/12
10/12
11/12
12/12

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/12][user-cr]: Second set of cleanups

Second set of cleanup patches. With these patches, LXC will be able to compile/link directly using restart.o and app-checkpoint.h from the user-cr directory. Something like:

USER_CR=/home/suka/user-cr make lxc_restart

After having more detailed discussions on the API, we could install restart.o in /lib/libcheckpoint.a and app-checkpoint.h in /usr/include.

	[PATCH 01/12][user-cr] restart: Mark globals as static
	[PATCH 02/12][user-cr] restart: Add args->send_sigint
	[PATCH 03/12][user-cr] Add app_restart_args->debug
	[PATCH 04/12][user-cr] Add app_restart_args->verbose
	[PATCH 05/12][user-cr] Add app_restart_args->ulogfd
	[PATCH 06/12][user-cr] Add app_restart_args->uerrfd
	[PATCH 07/12][user-cr] Define INIT_SIGNAL_ARRAY
	[PATCH 08/12][user-cr] Create common.h 
	[PATCH 09/12][user-cr] Create app-checkpoint.h
	[PATCH 10/12][user-cr] restart: Move main() to restart-main.c
	[PATCH 11/12][user-cr] checkpoint: Move main() to checkpoint-main.c
	[PATCH 12/12][user-cr] Have app_restart() return pid