Skip to content

Enable linking with LIBLXC

Sukadev Bhattiprolu containers 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest14 patches 3 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/14Add app_restart_args->debugrestart.c+4 -10 replies
2/14Add app_restart_args->verboserestart.c+3 -10 replies
3/14Add app_restart_args->ulogfdrestart.c+3 -00 replies
4/14Add app_restart_args->uerrfdrestart.c+3 -00 replies
5/14Define INIT_SIGNAL_ARRAYrestart.c+40 -360 replies
6/14Create common.hMakefile checkpoint.c common.h +1 more+119 -1380 replies
7/14Create app-checkpoint.hMakefile app-checkpoint.h checkpoint.c +1 more+51 -330 replies
8/14restart: Move main() to restart-main.cMakefile restart-main.c restart.c+353 -3320 replies
9/14checkpoint: Move main() to checkpoint-main.cMakefile checkpoint-main.c checkpoint.c+174 -1580 replies
10/14Have app_restart() return pidrestart-main.c restart.c+12 -10 replies
11/14restart: Define process_args()restart.c+20 -70 replies
12/14app_restart(): mnt-pty implies mntnsrestart-main.c restart.c+3 -40 replies
13/14restart: Move args checking to app_restart()restart-main.c restart.c+37 -320 replies
14/14Minimize unshare() callsrestart.c+60 -202 replies

Reviews trailers per patch

1 of 14 patches has a Reviewed-by or Acked-by.

PatchSerge Hallyn
1/14
2/14
3/14
4/14
5/14
6/14
7/14
8/14
9/14
10/14
11/14
12/14
13/14
14/14A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.

Read the v1 thread

Cover letter [PATCH 0/14][user-cr] Enable linking with LIBLXC

Patches to enable linking LIBLXC with USERCR.

Patches 1 through 9 are simply rebased patches due to the dropping of one of the earlier patches (Oren had nacked one patch in my earlier set. See

https://lists.linux-foundation.org/pipermail/containers/2010-March/023564.html

Patches 10 through 14 are additional changes needed to get LXC checkpoint and restart to work.

[PATCH 01/14] Add app_restart_args->debug [PATCH 02/14] Add app_restart_args->verbose [PATCH 03/14] Add app_restart_args->ulogfd [PATCH 04/14] Add app_restart_args->uerrfd [PATCH 05/14] Define INIT_SIGNAL_ARRAY
[PATCH 06/14] Create common.h
[PATCH 07/14] Create app-checkpoint.h
[PATCH 08/14] restart: Move main() to restart-main.c [PATCH 09/14] checkpoint: Move main() to checkpoint-main.c

[PATCH 10/14] Have app_restart() return pid [PATCH 11/14] restart: Define process_args() [PATCH 12/14] app_restart(): mnt-pty implies mntns [PATCH 13/14] restart: Move args checking to app_restart() [PATCH 14/14] Minimize unshare() calls

With these patches, USERCR exports app_checkpoint() and app_restart() functions in checkpoint.o and restart.o. LXC links directly with these .o files to checkpoint/restart its containers.