Skip to content

hid: new driver for PicoLCD device

Bruno Prémont linux-fbdev linux-input lkml 4 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v6 Latest8 patches 11 repliesIn review
  2. v43 of 6 patches 3 repliesSuperseded
  3. v36 patches 6 repliesSuperseded
Earlier versions · 1
VersionPostedPatchesRepliesStatus
v26 patches13 repliesSuperseded

Patches in v6 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8hid: new driver for PicoLCD deviceDocumentation/ABI/testing/sysfs-driver-hid-picolcd drivers/hid/Kconfig drivers/hid/Makefile +3 more+1223 -03 replies
2/8hid: add framebuffer support to PicoLCD deviceDocumentation/ABI/testing/sysfs-driver-hid-picolcd drivers/hid/Kconfig drivers/hid/hid-picolcd.c +1 more+590 -20 replies
3/8hid: add backlight support to PicoLCD devicedrivers/hid/Kconfig drivers/hid/hid-picolcd.c+128 -20 replies
4/8hid: add lcd support to PicoLCD devicedrivers/hid/Kconfig drivers/hid/hid-picolcd.c+107 -10 replies
5/8hid: add GPO (leds) support to PicoLCD devicedrivers/hid/Kconfig drivers/hid/hid-picolcd.c+166 -30 replies
6/8hid: add experimental access to PicoLCD device's EEPROM and FLASHdrivers/hid/Kconfig drivers/hid/hid-picolcd.c+423 -180 replies
7/8hid: add suspend/resume hooks for hid driversdrivers/hid/usbhid/hid-core.c include/linux/hid.h+26 -19 replies
8/8hid: add PM support to PicoLCD devicedrivers/hid/hid-picolcd.c+42 -00 replies

Reviews trailers per patch

No Reviewed-by, Acked-by or Tested-by trailers for v6 yet.

Read the v6 thread

Cover letter [PATCH v6 0/8] hid: new driver for PicoLCD device
Quoted 2 lines · On Tue, 30 March 2010 Jiri Kosina <[email protected]> wrote:

so please either remove the parts that depend on power management for now, or I'll wait on your respin of the generic HID-PM patch.

Here I respin the whole series, with PM moved to patch n°8 and patch n°7 being my original generic HID-PM.
Without the PM part there is one compiler warning about defined but unused function (picolcd_resume_backlight), I hope this is not an issue. If it is that function can move over to the PM patch (with it's stub for !CONFIG_BACKLIGHT_CLASS_DEVICE case)

So for now you can skip the last two patches during merge.

Do you have any suggestions regarding generic HID-PM as to how much and how it should be visible to the HID driver?

Thanks,
Bruno