Numa: Use Generic Per-cpu Variables for numa_*_id()
Get series with b4
b4 am [email protected]Versions newest first
- v1 Latest8 patches 20 repliesIn review
Patches in v1 No applies recorded yet
| # | Subject and files | Size | Replies | Applied |
|---|---|---|---|---|
| 1/8 | numa: add generic percpu var numa_node_id() implementationinclude/ mm/ | +33 | 4 replies | |
| 2/8 | numa: x86_64: use generic percpu var numa_node_id() implementationarch/ arch/ arch/ +2 more | +19 | 5 replies | |
| 3/8 | numa: ia64: use generic percpu var numa_node_id() implementationarch/ arch/ arch/ | +10 | 1 reply | |
| 4/8 | numa: Introduce numa_mem_id()- effective local memory node idinclude/ include/ include/ +1 more | +71 | 1 reply | |
| 5/8 | numa: ia64: support numa_mem_id() for memoryless nodesarch/ arch/ | +5 | 1 reply | |
| 6/8 | numa: slab: use numa_mem_id() for slab local memory nodemm/ | +22 | 4 replies | |
| 7/8 | numa: in-kernel profiling: use cpu_to_mem() for per cpu allocationskernel/ | +2 | 0 replies | |
| 8/8 | numa: update Documentation/vm/numa, add memoryless node infoDocumentation/ | +146 | 2 replies |
Reviews trailers per patch
3 of 8 patches have a Reviewed-by or Acked-by.
| Patch | Christoph Lameter | KAMEZAWA Hiroyuki |
|---|---|---|
| 1/8 | R-b | R-b |
| 2/8 | ||
| 3/8 | R-b | Reviewd-by |
| 4/8 | ||
| 5/8 | ||
| 6/8 | ||
| 7/8 | ||
| 8/8 | R-b |
Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes.
Cover letter [PATCH 0/8] Numa: Use Generic Per-cpu Variables for numa_*_id()
Use Generic Per cpu infrastructure for numa_*_id() V4
Series Against: 2.6.34-rc3-mmotm-100405-1609
Background:
V1 of this series resolved a fairly serious performance problem on our ia64 platforms with memoryless nodes because SLAB cannot cache object from a remote node, even tho' that node is the effective "local memory node" for a given cpu. V1 caused no regression in x86_64 [a slight improvement even] for the admittedly few tests that I ran.
Christoph Lameter suggested the approach implemented in V2 and later: define a new function--numa_mem_id()--that returns the "local memory node" for cpus attached to memoryless nodes. Christoph also suggested that, while at it, I could modify the implementation of numa_node_id() [and the related cpu_to_node()] to use the generic percpu variable implementation.
While implementing V2, I encountered a circular header dependency between:
topology.h -> percpu.h -> slab.h -> gfp.h -> topology.h
I resolved this by moving the generic percpu functions to include/asm-generic/percpu.h so that various arch asm/percpu.h could include that, and topology.h could include asm/percpu.h to avoid including slab.h, breaking the circular dependency. Reviewers didn't like that. Matthew Willcox suggested that I uninline percpu_alloc()/free() for the !SMP config and remove slab.h from percpu.h. I tried that. I broke the build of a LOT of files. Tejun Heo mentioned that percpu-defs.h would be a better place for the generic function definitions. V3 implemented that suggestion.
Later, Tejun decided to jump in and remove slab.h from percpu.h and semi- automagically fix up all of the affected modules. V4 is implemented atop Tejun's series now in mmotm. Again, this solves the slab performance problem on our servers configured with memoryless nodes, and shows no regression with hackbench on x86_64. Of course, more performance testing would be welcome.
The slab changes in patch 6 of the series need review w/rt to node hot plug that could change the effective "local memory node" for a memoryless node by inserting a "nearer" node in the zonelists. An additional patch may be required to address this.
Lee