Skip to content

Fix performance issue with ondemand governor

Arjan van de Ven lkml 2 versions – In review

Get series with b4
b4 am [email protected]

Versions newest first · linked by author and title

  1. v2 Latest8 patches 11 repliesIn review
  2. v17 patches 45 repliesSuperseded

Patches in v2 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/8sched: Add a comment to get_cpu_idle_time_us()kernel/time/tick-sched.c+14 -01 reply
2/8sched: Introduce a function to update the idle statisticskernel/time/tick-sched.c+19 -101 reply
3/8sched: Update the idle statistics in get_cpu_idle_time_us()kernel/time/tick-sched.c+6 -11 reply
4/8sched: Fold updating of the last_update_time_info into update_ts_time_stats()kernel/time/tick-sched.c+11 -111 reply
5/8sched: Eliminate the ts->idle_lastupdate fieldinclude/linux/tick.h kernel/time/tick-sched.c+1 -51 reply
6/8sched: Intoduce get_cpu_iowait_time_us()include/linux/tick.h kernel/time/tick-sched.c kernel/time/timer_list.c+33 -01 reply
7/8ondemand: Solve a big performance issue by counting IOWAIT time as busydrivers/cpufreq/cpufreq_ondemand.c+28 -21 reply
8/8ondemand: Make the iowait-is-busy time a sysfs tunabledrivers/cpufreq/cpufreq_ondemand.c+45 -11 reply

Reviews trailers per patch

All 8 patches have a Reviewed-by or Acked-by.

PatchRik van RielPavel MachekPeter Zijlstra
1/8R-b R-b A-b
2/8R-b R-b A-b
3/8R-b R-b A-b
4/8R-b R-b A-b
5/8R-b R-b A-b
6/8R-b R-b A-b
7/8R-b R-b A-b
8/8A-b A-b A-b A-b A-b

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 3 reviewers.

Read the v2 thread

Cover letter [PATCH v2 0/8] Fix performance issue with ondemand governor

[Version 2 includes the acks/etc. Andrew: no changes from the patches that are in -mm]

There have been various reports of the ondemand governor causing some serious performance issues, one of the latest ones from Andrew. There are several fundamental issues with ondemand (being worked on), but the report from Andrew can be fixed relatively easily.

The fundamental issue is that ondemand will go to a (too) low CPU frequency for workloads that alternatingly disk and CPU bound...

Signature · 3 lines
Arjan van de Ven 	Intel Open Source Technology Centre
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org