Skip to content

vmscan: cut down on struct scan_control

Johannes Weiner linux-mm 1 version In review

Get series with b4
b4 am [email protected]

Versions newest first

  1. v1 Latest5 patches 11 repliesIn review

Patches in v1 No applies recorded yet

#Subject and filesSizeRepliesApplied
1/5vmscan: fix unmapping behaviour for RECLAIM_SWAPmm/vmscan.c+2 -22 replies
2/5vmscan: remove may_unmap scan controlmm/vmscan.c+0 -120 replies
3/5vmscan: remove all_unreclaimable scan controlmm/vmscan.c+6 -89 replies
4/5vmscan: remove isolate_pages callback scan controlinclude/linux/memcontrol.h mm/vmscan.c+35 -303 replies
5/5vmscan: remove may_swap scan controlinclude/linux/swap.h mm/memcontrol.c mm/vmscan.c+20 -243 replies

Reviews trailers per patch

1 of 5 patches has a Reviewed-by or Acked-by.

PatchKOSAKI MotohiroKAMEZAWA HiroyukiBalbir SinghGreg ThelenJohannes Weiner
1/5
2/5
3/5R-b A-b A-b T-b A-b
4/5
5/5

Trailers given in replies are filled; those carried in the patches from earlier versions are outlined with dashes. Scroll the table sideways for all 5 reviewers.

Read the v1 thread

Cover letter [patch 0/5] vmscan: cut down on struct scan_control

Hi,

here are 5 patches that remove 4 members from struct scan_control.

sc->may_unmap is no longer used after patch #1, sc->may_swap is folded into sc->swappiness, sc->all_unreclaimable is made a return value, and sc->isolate_pages is replaced with a branch on sc->mem_cgroup (reusing a nearby branch, so no additional one) and direct function calling.

So nothing too spectecular. It saves a bit of code and 2 to 4 stack words depending on the wordsize and call path.

Hannes

 include/linux/memcontrol.h |   13 +++--
 include/linux/swap.h       |    4 -
 mm/memcontrol.c            |   13 +++--
 mm/vmscan.c                |  105 ++++++++++++++++++---------------------------
 4 files changed, 61 insertions(+), 74 deletions(-)

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to [email protected]. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"[email protected]"> [email protected] </a>